There are instances of both "authorized" and "authorised" in Koha's templates. With all due respect to the rest of the world, the default en templates do stick to American spelling.
Created attachment 18680 [details] [review] Bug 10420 - Standardize spelling of "authorized" This patch corrects instances of the non-[American]-standard spelling "authorised" when used in text. The following instances are corrected: - In Administration -> Funds, the error message displayed if you do not have permission to edit a fund. - In Administration -> Authorized values, the instructions linked to the "Libraries limitation" field. - In Administration -> MARC bibliographic framework test, instructions related to linking to authorized values. - In the course reserves add form, error messages referring to missing authorized values. - In guided reports, error messages shown when an authorized value chosen as a report parameter doesn't exit.
I've pondered submitting this same patch myself, but I've wondered which form is the best. Since there are translation files for English (UK) and English (New Zealand), does it make sense for English (American) to be the default language for Koha? Unconsciously, I tend to write in American English, although since moving to Australia, I tend to change my Z to an S in many cases for writing email. Should there be a recommendation somewhere that people write (at least in templates) in American English?
Created attachment 18740 [details] [review] Bug 10420 - Standardize spelling of "authorized" This patch corrects instances of the non-[American]-standard spelling "authorised" when used in text. The following instances are corrected: - In Administration -> Funds, the error message displayed if you do not have permission to edit a fund. - In Administration -> Authorized values, the instructions linked to the "Libraries limitation" field. - In Administration -> MARC bibliographic framework test, instructions related to linking to authorized values. - In the course reserves add form, error messages referring to missing authorized values. - In guided reports, error messages shown when an authorized value chosen as a report parameter doesn't exit. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
I am certainly not in the best position to take a part in this debate (...) but why do you choose the American spelling as "standard"? http://grammarist.com/spelling/authorise-authorize/
(In reply to comment #4) > I am certainly not in the best position to take a part in this debate (...) > but why do you choose the American spelling as "standard"? > > http://grammarist.com/spelling/authorise-authorize/ Because the rest of Koha already uses US spelling ("cataloging," "authorized" in most places, "check out," etc.).
And the point isn't that American spelling is "standard," just that it is the convention for Koha templates.
QA comment: As reported on the wiki page http://wiki.koha-community.org/wiki/Installation_of_additional_languages_for_OPAC_and_INTRANET_staff_client the default language used into Koha is american english. This patch is a string patch, no regression possible. Marked as Passed QA.
Created attachment 18755 [details] [review] Bug 10420 - Standardize spelling of "authorized" This patch corrects instances of the non-[American]-standard spelling "authorised" when used in text. The following instances are corrected: - In Administration -> Funds, the error message displayed if you do not have permission to edit a fund. - In Administration -> Authorized values, the instructions linked to the "Libraries limitation" field. - In Administration -> MARC bibliographic framework test, instructions related to linking to authorized values. - In the course reserves add form, error messages referring to missing authorized values. - In guided reports, error messages shown when an authorized value chosen as a report parameter doesn't exit. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Pushed to master. Thanks, Owen! (In reply to comment #6) > And the point isn't that American spelling is "standard," just that it is > the convention for Koha templates. Indeed. If the consensus swings the other way in time and folks want to write templates in en-GB or en-NZ, that's fine. Speaking as a USian, we're perfectly capable of using 's's and extra 'u's. We just need to pick one at any given point in time.
This patch has been pushed to 3.12.x, will be in 3.12.1. Minor merge conflict regarding course reserves. Thanks Owen!
Does not apply to 3.10.x, please send a new patch if it is needed for 3.10.x