Bug 10420 - Standardize spelling of "authorized"
Summary: Standardize spelling of "authorized"
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Jonathan Druart
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-05 14:37 UTC by Owen Leonard
Modified: 2014-12-07 20:02 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 10420 - Standardize spelling of "authorized" (8.05 KB, patch)
2013-06-05 15:10 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 10420 - Standardize spelling of "authorized" (8.06 KB, patch)
2013-06-07 12:55 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 10420 - Standardize spelling of "authorized" (8.21 KB, patch)
2013-06-07 14:32 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2013-06-05 14:37:57 UTC
There are instances of both "authorized" and "authorised" in Koha's templates. With all due respect to the rest of the world, the default en templates do stick to American spelling.
Comment 1 Owen Leonard 2013-06-05 15:10:56 UTC Comment hidden (obsolete)
Comment 2 David Cook 2013-06-05 23:44:45 UTC
I've pondered submitting this same patch myself, but I've wondered which form is the best. Since there are translation files for English (UK) and English (New Zealand), does it make sense for English (American) to be the default language for Koha? 

Unconsciously, I tend to write in American English, although since moving to Australia, I tend to change my Z to an S in many cases for writing email.

Should there be a recommendation somewhere that people write (at least in templates) in American English?
Comment 3 Kyle M Hall 2013-06-07 12:55:16 UTC Comment hidden (obsolete)
Comment 4 Jonathan Druart 2013-06-07 13:21:46 UTC
I am certainly not in the best position to take a part in this debate (...) but why do you choose the American spelling as "standard"?

http://grammarist.com/spelling/authorise-authorize/
Comment 5 Jared Camins-Esakov 2013-06-07 13:32:37 UTC
(In reply to comment #4)
> I am certainly not in the best position to take a part in this debate (...)
> but why do you choose the American spelling as "standard"?
> 
> http://grammarist.com/spelling/authorise-authorize/

Because the rest of Koha already uses US spelling ("cataloging," "authorized" in most places, "check out," etc.).
Comment 6 Owen Leonard 2013-06-07 14:03:23 UTC
And the point isn't that American spelling is "standard," just that it is the convention for Koha templates.
Comment 7 Jonathan Druart 2013-06-07 14:31:57 UTC
QA comment:

As reported on the wiki page http://wiki.koha-community.org/wiki/Installation_of_additional_languages_for_OPAC_and_INTRANET_staff_client the default language used into Koha is american english.

This patch is a string patch, no regression possible.

Marked as Passed QA.
Comment 8 Jonathan Druart 2013-06-07 14:32:21 UTC
Created attachment 18755 [details] [review]
Bug 10420 - Standardize spelling of "authorized"

This patch corrects instances of the non-[American]-standard spelling
"authorised" when used in text.

The following instances are corrected:

- In Administration -> Funds, the error message displayed if you do not
  have permission to edit a fund.
- In Administration -> Authorized values, the instructions linked to the
  "Libraries limitation" field.
- In Administration -> MARC bibliographic framework test, instructions
  related to linking to authorized values.
- In the course reserves add form, error messages referring to missing
  authorized values.
- In guided reports, error messages shown when an authorized value
  chosen as a report parameter doesn't exit.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 9 Galen Charlton 2013-06-07 15:32:19 UTC
Pushed to master.  Thanks, Owen!

(In reply to comment #6)
> And the point isn't that American spelling is "standard," just that it is
> the convention for Koha templates.

Indeed.  If the consensus swings the other way in time and folks want to write templates in en-GB or en-NZ, that's fine.  Speaking as a USian, we're perfectly capable of using 's's and extra 'u's.

We just need to pick one at any given point in time.
Comment 10 Tomás Cohen Arazi 2013-06-10 18:04:23 UTC
This patch has been pushed to 3.12.x, will be in 3.12.1. Minor merge conflict regarding course reserves.

Thanks Owen!
Comment 11 Bernardo Gonzalez Kriegel 2013-06-14 20:25:59 UTC
Does not apply to 3.10.x, please send a new patch if it is needed for 3.10.x