Bug 10425 - Help page missing for Local Use preferences
Summary: Help page missing for Local Use preferences
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Documentation (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Fridolin Somers
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-06 08:56 UTC by Fridolin Somers
Modified: 2014-12-07 20:03 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Proposed patch (4.39 KB, patch)
2013-06-06 09:00 UTC, Fridolin Somers
Details | Diff | Splinter Review
Bug 10425 - Help page missing for Local Use preferences (4.46 KB, patch)
2013-06-07 12:53 UTC, Kyle M Hall
Details | Diff | Splinter Review
Proposed patch (new help page) (1.67 KB, patch)
2013-06-12 12:35 UTC, Fridolin Somers
Details | Diff | Splinter Review
Bug 10425 - Help page missing for Local Use preferences (1.77 KB, patch)
2013-06-14 08:54 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Fridolin Somers 2013-06-06 08:56:22 UTC
When viewing Local Use system preferences tab, the help button will lead to an error page.
This is because Local Use tab uses not the same script has other tabs : systempreferences.pl.
Comment 1 Fridolin Somers 2013-06-06 09:00:05 UTC Comment hidden (obsolete)
Comment 2 Kyle M Hall 2013-06-07 12:53:36 UTC Comment hidden (obsolete)
Comment 3 Marcel de Rooy 2013-06-10 09:26:15 UTC
QA Comment:

For simplification, I would suggest not to copy information and create redundancy ;) but just explain what is a local use preference.
What all the other pages do, is already there.
Any change to the other page will be forgotten for your new page..

Or put them in an include?
Comment 4 Fridolin Somers 2013-06-12 12:35:48 UTC Comment hidden (obsolete)
Comment 5 Fridolin Somers 2013-06-12 12:40:06 UTC
(In reply to comment #3)
> For simplification, I would suggest not to copy information and create
> redundancy ;) but just explain what is a local use preference.
Your right, I've rewritten the patch to provide in help page some explanations on local use system preferences.
Comment 6 Marcel de Rooy 2013-06-14 08:43:22 UTC
(In reply to comment #5)
> (In reply to comment #3)
> > For simplification, I would suggest not to copy information and create
> > redundancy ;) but just explain what is a local use preference.
> Your right, I've rewritten the patch to provide in help page some
> explanations on local use system preferences.

Thanks for that. Looking at this now.
Comment 7 Marcel de Rooy 2013-06-14 08:54:45 UTC
Created attachment 18979 [details] [review]
Bug 10425 - Help page missing for Local Use preferences

When viewing Local Use system preferences tab, the help button will lead to an error page.
This is because Local Use tab uses not the same script has other tabs : systempreferences.pl.

This patch adds help/systemprefences.tt

Test plan :
- Go to Local Use preferences : /cgi-bin/koha/admin/systempreferences.pl
- Click on Help link (at right top)
- See you get the same page as other preferences tab help

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 8 Marcel de Rooy 2013-06-14 08:57:11 UTC
Passed QA
Comment 9 Galen Charlton 2013-06-14 15:34:23 UTC
Pushed to master, along with a minor follow-up tweaking the text.

Thanks, Fridolyn!
Comment 10 Tomás Cohen Arazi 2013-07-01 19:07:24 UTC
This patch has been pushed to 3.12.x, will be in 3.12.2.

Thanks Fridolyn!
Comment 11 Fridolin Somers 2013-07-02 08:43:37 UTC
Thanks everybody.
Comment 12 Bernardo Gonzalez Kriegel 2013-07-13 17:29:06 UTC
Pushed to 3.10.x, will be in 3.10.8
Comment 13 Chris Hall 2013-07-18 08:57:19 UTC
Pushed to 3.8.x, will be in 3.8.15