When viewing Local Use system preferences tab, the help button will lead to an error page. This is because Local Use tab uses not the same script has other tabs : systempreferences.pl.
Created attachment 18695 [details] [review] Proposed patch See commit message
Created attachment 18739 [details] [review] Bug 10425 - Help page missing for Local Use preferences When viewing Local Use system preferences tab, the help button will lead to an error page. This is because Local Use tab uses not the same script has other tabs : systempreferences.pl. This patch simply copies help/prefences.tt as help/systemprefences.tt Test plan : - Go to Local Use preferences : /cgi-bin/koha/admin/systempreferences.pl - Click on Help link (at right top) - See you get the same page as other preferences tab help Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
QA Comment: For simplification, I would suggest not to copy information and create redundancy ;) but just explain what is a local use preference. What all the other pages do, is already there. Any change to the other page will be forgotten for your new page.. Or put them in an include?
Created attachment 18889 [details] [review] Proposed patch (new help page)
(In reply to comment #3) > For simplification, I would suggest not to copy information and create > redundancy ;) but just explain what is a local use preference. Your right, I've rewritten the patch to provide in help page some explanations on local use system preferences.
(In reply to comment #5) > (In reply to comment #3) > > For simplification, I would suggest not to copy information and create > > redundancy ;) but just explain what is a local use preference. > Your right, I've rewritten the patch to provide in help page some > explanations on local use system preferences. Thanks for that. Looking at this now.
Created attachment 18979 [details] [review] Bug 10425 - Help page missing for Local Use preferences When viewing Local Use system preferences tab, the help button will lead to an error page. This is because Local Use tab uses not the same script has other tabs : systempreferences.pl. This patch adds help/systemprefences.tt Test plan : - Go to Local Use preferences : /cgi-bin/koha/admin/systempreferences.pl - Click on Help link (at right top) - See you get the same page as other preferences tab help Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Passed QA
Pushed to master, along with a minor follow-up tweaking the text. Thanks, Fridolyn!
This patch has been pushed to 3.12.x, will be in 3.12.2. Thanks Fridolyn!
Thanks everybody.
Pushed to 3.10.x, will be in 3.10.8
Pushed to 3.8.x, will be in 3.8.15