Whis a translated intranet (ie fr-FR) the status filter does not work for "Late" status. It is because status in combobox filter is translated "Retard" and status in table is translated "En retard". We could change translation but it would be better if filter did not work on status name.
[With] a translated intranet. Sorry :)
I also created Bug 10429 for branch filter
Created attachment 18748 [details] [review] Proposed patch See commit message
I update to major importance because many libraries have reported this bug.
Should we be using a class, and then selecting on a class when we could/should be using and id?
I used a class because there are several cells to identify ; an id must be unique.
I set back to Need Signoff. The QA validation will say if using a class is correct.
Created attachment 20197 [details] [review] Bug 10430 - status filter not working in serial claims when translated With a translated intranet (ie fr-FR) the status filter does not work for "Late" status. It is because status in combobox filter is translated "Retard" and status in table is translated "En retard". This patch changed javascript filter to work on a status code instead of status name. The new classes may be used to change CSS depending on status. Test plan : - Use a translated intranet (ie fr-FR) - Go to serials claim of a vendor with issues of multiple status - Check that status filter does its work Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
You do realise I am on the QA team right? However I have signed off, someone elses problem now.
(In reply to Chris Cormack from comment #9) > You do realise I am on the QA team right? Yes sorry, of course I know it, I surly had an amnesia moment. In fact I do not understand how it could use an id. Could you give a piece of code ? Looking at Bug 10429 it appears there are several bugs on those filters. They all could be solved by using a JQuery Datatable for claims table.
This patch works nicely and the classes are correct, as every status can show up multiple times in this table. But I am a bit confused about "Arrived" and "Stopped" showing up in this list. I checked the code and I think the pull down of filters should only have: Missing, Expected, Late, and Claimed. ----- =head2 GetLateOrMissingIssues ... AND (serial.STATUS = 4 OR ((planneddate < now() AND serial.STATUS =1) OR serial.STATUS = 3 OR serial.STATUS = 7)) From the reports help: 1 = Expected 2 = Arrived 3 = Late 4 = Missing 5 = Not Available 6 = Delete 7 = Claimed 8 = Stopped This patch only adds 'Stopped', the other status have been there before. I think this can be fixed in a follow up.
Created attachment 20588 [details] [review] [PASSED QA] Bug 10430 - status filter not working in serial claims when translated With a translated intranet (ie fr-FR) the status filter does not work for "Late" status. It is because status in combobox filter is translated "Retard" and status in table is translated "En retard". This patch changed javascript filter to work on a status code instead of status name. The new classes may be used to change CSS depending on status. Test plan : - Use a translated intranet (ie fr-FR) - Go to serials claim of a vendor with issues of multiple status - Check that status filter does its work Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Patch passes all tests and QA script. The status filter should probably be changed to only allow filtering on status that can appear on the page.
Created attachment 20704 [details] [review] Bug 10430 - arrived and stopped status are not possible in serial claim Follow up to remove arrived and stopped status, as asked.
(In reply to Katrin Fischer from comment #11) > I think this can be fixed in a follow up. I added follow-up but did not change the bug status. I let you manage it.
Pushed to master. Thanks, Fridolyn!
This patch has been pushed to 3.12.x, will be in 3.12.7. Thanks Fridolyn!