Created attachment 18763 [details] Spanish Zebra language definition file It seems we have available for 'en', 'fr', 'nb', 'ru', 'uk' for ZEBRA_LANGUAGE on /etc/koha/koha-sites.conf But with the attached sort-string-utf.chr Spanish Zebra language definition file this language could also be available. And like Galen says [1]: > In addition to creating a new directory under lang_defs, you would need to > update zebra-biblios.cfg and/or zebra-biblios-dom.cfg > and zebra-authorities.cfg/zebra-authorities-dom.cfg to point to the new > directory and restart your Zebra server. For the purpose of making a > patch, in addition to adding etc/zebradb/lang_defs/XXX, you should patch > Makefile.PL so that the new languages are available as options to set > ZEBRA_LANGUAGE during installation. [1] http://lists.katipo.co.nz/public/koha/2013-January/035288.html
Created attachment 18843 [details] [review] Bug 10431 - Spanish Zebra character sorting file This patch provides a definition file for spanish (es) character sorting in Zebra. It is based on the ideas from Hugo Agud <hagud@orex.es> and Pablo Bianchi <pablo.bianchi@gmail.com>. Makefile.PL is fixed to notice the existence of the 'es' language. The docs for koha-create are touched too. To test: Tarball ======= - Go through the install process, choosing 'es' for the Zebra's language step - Koha should work as usual. - Running this should show the lang definition is properly set. $ grep -R "lang_defs/es" /etc/koha/* (stuff like zebradb/zebra-biblios-dom.cfg:profilePath:...etc/koha/zebra/lang_defs/es... should show) - This file should be present: /etc/koha/zebradb/lang_defs/es/sort-string-utf.chr Packages ======== - Build your own package, it shouldn't break the packaging - Try the new package, using koha-create to set an instance using --lang 'es' Regards To+ Sponsored-by: Universidad Nacional de Córdoba
I thought of adding a followup for enabling 'ru' and 'uk' too, which already had their language definitions in place. I chose to fill a new bug for that, which depends on this one. Its bug 10447. Regards To+
Marking failed QA - when I applied the patch with git-bz, the character map file was in the ISO-8859-1 character encoding; it needs to use UTF-8.
Created attachment 19136 [details] [review] Bug 10431 - Spanish Zebra character sorting file This patch provides a definition file for spanish (es) character sorting in Zebra. It is based on the ideas from Hugo Agud <hagud@orex.es> and Pablo Bianchi <pablo.bianchi@gmail.com>. Makefile.PL is fixed to notice the existence of the 'es' language. The docs for koha-create are touched too. To test: Tarball ======= - Go through the install process, choosing 'es' for the Zebra's language step - Koha should work as usual. - Running this should show the lang definition is properly set. $ grep -R "lang_defs/es" /etc/koha/* (stuff like zebradb/zebra-biblios-dom.cfg:profilePath:...etc/koha/zebra/lang_defs/es... should show) - This file should be present: /etc/koha/zebradb/lang_defs/es/sort-string-utf.chr Packages ======== - Build your own package, it shouldn't break the packaging - Try the new package, using koha-create to set an instance using --lang 'es' Regards To+ Edit: original file was ISO-8859-1, fixed. Sponsored-by: Universidad Nacional de Córdoba
Created attachment 19144 [details] [review] Bug 10431 - Spanish Zebra character sorting file This patch provides a definition file for Spanish (es) character sorting in Zebra. It is based on the ideas from Hugo Agud <hagud@orex.es> and Pablo Bianchi <pablo.bianchi@gmail.com>. Makefile.PL is fixed to notice the existence of the 'es' language. The docs for koha-create are touched too. To test: Tarball ======= - Go through the install process, choosing 'es' for the Zebra's language step - Koha should work as usual. - Running this should show the lang definition is properly set. $ grep -R "lang_defs/es" /etc/koha/* (stuff like zebradb/zebra-biblios-dom.cfg:profilePath:...etc/koha/zebra/lang_defs/es... should show) - This file should be present: /etc/koha/zebradb/lang_defs/es/sort-string-utf.chr Packages ======== - Build your own package, it shouldn't break the packaging - Try the new package, using koha-create to set an instance using --lang 'es' Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Created attachment 19218 [details] [review] Bug 10431 - Redundant mappings removed
There were some chars I overlooked that ended up being redundant mappings. zerbaidx warns about them when run in verbose mode from rebuild_zebra.pl. Several chars were mapped into their "parent" ascii char, but also set an order in the lowercase and uppercase definitions.
Created attachment 19222 [details] [review] Signed off patch
Created attachment 19223 [details] [review] Signed off patch
Created attachment 19409 [details] [review] Bug 10431 - Spanish Zebra character sorting file
Created attachment 19410 [details] [review] Bug 10431 - Redundant mappings removed
Pushed to master. Thanks, Tomás!
This patch has been pushed to 3.12.x, will be in 3.12.2. Thanks Pablo for reporting!