opac/opac-reserve.pl contains some code to calculate how many columns of the main table that the item selection sub-table (and the hold note entry field) should span. As the colspan value is purely a display consideration, the logic should be moved to the template.
After some grepping, I've turned up one other example of a colspan value being calculated in the script, not the template: members/statistics.pl: length_keys => scalar( @statistic_column_names), koha-tmpl/intranet-tmpl/prog/en/modules/members/statistics.tt: <td colspan="[% length_keys %]">TOTAL</td>
Created attachment 30470 [details] [review] Bug 10433 - colspan calculation done by opac/opac-reserve.pl should be moved to template Since the bootstrap OPAC's place hold interface doesn't use tables there is no use for the colspan calculation being done in the script. This patch removes it. To test, place one or more holds in the OPAC and confirm that there are no display problems. The OPAC error logs should show no associated error.
> members/statistics.pl: length_keys => scalar( @statistic_column_names), I have moved this issue to Bug 12693
Created attachment 30650 [details] [review] [SIGNED-OFF] Bug 10433 - colspan calculation done by opac/opac-reserve.pl should be moved to template Since the bootstrap OPAC's place hold interface doesn't use tables there is no use for the colspan calculation being done in the script. This patch removes it. To test, place one or more holds in the OPAC and confirm that there are no display problems. The OPAC error logs should show no associated error. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> No display problems, no related errors on log, no koha-qa errors
Created attachment 30802 [details] [review] [PASSED QA] Bug 10433 - colspan calculation done by opac/opac-reserve.pl should be moved to template Since the bootstrap OPAC's place hold interface doesn't use tables there is no use for the colspan calculation being done in the script. This patch removes it. To test, place one or more holds in the OPAC and confirm that there are no display problems. The OPAC error logs should show no associated error. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> No display problems, no related errors on log, no koha-qa errors Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes tests and QA script, no regressions found.
Patch pushed to master. Thanks Owen!