Bug 10433 - colspan calculation done by opac/opac-reserve.pl should be moved to template
Summary: colspan calculation done by opac/opac-reserve.pl should be moved to template
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact:
URL:
Keywords:
Depends on: 12233
Blocks:
  Show dependency treegraph
 
Reported: 2013-06-07 17:11 UTC by Galen Charlton
Modified: 2015-06-04 23:24 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 10433 - colspan calculation done by opac/opac-reserve.pl should be moved to template (1.44 KB, patch)
2014-08-01 18:41 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 10433 - colspan calculation done by opac/opac-reserve.pl should be moved to template (1.54 KB, patch)
2014-08-09 13:25 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
[PASSED QA] Bug 10433 - colspan calculation done by opac/opac-reserve.pl should be moved to template (1.64 KB, patch)
2014-08-14 20:10 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Galen Charlton 2013-06-07 17:11:10 UTC
opac/opac-reserve.pl contains some code to calculate how many columns of the main table that the item selection sub-table (and the hold note entry field) should span.

As the colspan value is purely a display consideration, the logic should be moved to the template.
Comment 1 Galen Charlton 2013-06-07 20:35:13 UTC
After some grepping, I've turned up one other example of a colspan value being calculated in the script, not the template:

members/statistics.pl:    length_keys    => scalar( @statistic_column_names),
koha-tmpl/intranet-tmpl/prog/en/modules/members/statistics.tt:                        <td colspan="[% length_keys %]">TOTAL</td>
Comment 2 Owen Leonard 2014-08-01 18:41:39 UTC Comment hidden (obsolete)
Comment 3 Owen Leonard 2014-08-01 18:56:44 UTC
> members/statistics.pl:    length_keys    => scalar( @statistic_column_names),

I have moved this issue to Bug 12693
Comment 4 Bernardo Gonzalez Kriegel 2014-08-09 13:25:05 UTC Comment hidden (obsolete)
Comment 5 Katrin Fischer 2014-08-14 20:10:42 UTC
Created attachment 30802 [details] [review]
[PASSED QA] Bug 10433 - colspan calculation done by opac/opac-reserve.pl should be moved to template

Since the bootstrap OPAC's place hold interface doesn't use tables
there is no use for the colspan calculation being done in the script.
This patch removes it.

To test, place one or more holds in the OPAC and confirm that there are
no display problems. The OPAC error logs should show no associated
error.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
No display problems, no related errors on log, no koha-qa errors

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passes tests and QA script, no regressions found.
Comment 6 Tomás Cohen Arazi 2014-10-30 01:13:30 UTC
Patch pushed to master.

Thanks Owen!