To reproduce: - switch on the the IndependentBranches pref - go on Home › Tools › Notices & Slips - click on a edit link - change the library and save => changes are not saved.
Created attachment 18818 [details] [review] Bug 10439: FIX modify the library for a notice. 2 javascript functions should be apply only in a specific case, not for all views. Test plan: - switch on the IndependentBranches pref - try to change the library for a notice. Before the patch, no change is applied.
Created attachment 18830 [details] [review] [SIGNED-OFF] Bug 10439: FIX modify the library for a notice. 2 javascript functions should be apply only in a specific case, not for all views. Signed-off-by: Srdjan <srdjan@catalyst.net.nz>
It actually affects "New Notice" as well
Created attachment 19044 [details] [review] [PASSED QA] Bug 10439: FIX modify the library for a notice. 2 javascript functions should be apply only in a specific case, not for all views. Test plan: - switch on the IndependentBranches pref - try to change the library for a notice. Before the patch, no change is applied. Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Note: only a superlibrarian can change the library or create new notices for every library. This bug can only be reproduced with superlibrarian permissions. Tested with independentbranches on/off. All tests and QA script pass.
Pushed to master. Thanks, Jonathan!
This patch has been pushed to 3.12.x, will be in 3.12.2. Thanks Jonathan!
Pushed to 3.10.x, will be in 3.10.8
Pushed to 3.8.x, will be in 3.8.15