Created attachment 18836 [details] [review] Bug 10444 - In advanced search(more), [+] and [-] should behave like links on hover This patch add href="#" to the [+] and [-] links for adding and removing search terms. It also defines its style so it doesn't show underlined. To test: - Browse your OPAC to "Advanced Search" and then "More options". - The [+] and [-] don't change the cursor on hover - Apply the patch, reload and see the cursor changes - Functionality should remain unchanged Regards To+ Sponsored-by: Universidad Nacional de Córdoba
Created attachment 18847 [details] [review] Bug 10444 - (CCSR followup) In advanced search(more), [+] and [-] should behave like links on hover Same fix for CCSR. Regards To+ Sponsored-by: Universidad Nacional de Córdoba
Created attachment 18851 [details] [review] [SIGNED-OFF] Bug 10444 - In advanced search(more), [+] and [-] should behave like links on hover This patch add href="#" to the [+] and [-] links for adding and removing search terms. It also defines its style so it doesn't show underlined. To test: - Browse your OPAC to "Advanced Search" and then "More options". - The [+] and [-] don't change the cursor on hover - Apply the patch, reload and see the cursor changes - Functionality should remain unchanged Regards To+ Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 18852 [details] [review] [SIGNED-OFF] Bug 10444 - (CCSR followup) In advanced search(more), [+] and [-] should behave like links on hover Same fix for CCSR. Regards To+ Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 18900 [details] [review] Bug 10444 - In advanced search(more), [+] and [-] should behave like links on hover This patch add href="#" to the [+] and [-] links for adding and removing search terms. It also defines its style so it doesn't show underlined. To test: - Browse your OPAC to "Advanced Search" and then "More options". - The [+] and [-] don't change the cursor on hover - Apply the patch, reload and see the cursor changes - Functionality should remain unchanged Regards To+ Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Amended patch: Add the onclick event on the 2 links
Created attachment 18901 [details] [review] Bug 10444 - (CCSR followup) In advanced search(more), [+] and [-] should behave like links on hover Same fix for CCSR. Regards To+ Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 18902 [details] [review] Bug 10444 - (CCSR followup) In advanced search(more), [+] and [-] should behave like links on hover Same fix for CCSR. Regards To+ Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
QA comment: Works as expected except for the click reset the scroll at the top. I amended the patch in order to add a onclick and to trigger the event. Marked as Passed QA.
(In reply to comment #8) > QA comment: > Works as expected except for the click reset the scroll at the top. I > amended the patch in order to add a onclick and to trigger the event. > Marked as Passed QA. I'm not quite sure that your amendment was attached to this bug -- please double-check.
Created attachment 18906 [details] [review] Bug 10444 - In advanced search(more), [+] and [-] should behave like links on hover This patch add href="#" to the [+] and [-] links for adding and removing search terms. It also defines its style so it doesn't show underlined. To test: - Browse your OPAC to "Advanced Search" and then "More options". - The [+] and [-] don't change the cursor on hover - Apply the patch, reload and see the cursor changes - Functionality should remain unchanged Regards To+ Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Amended patch: Add the onclick event on the 2 links
I disagree with how the QA modification was implemented. Rather than adding onclick attributes, the existing jQuery click handlers should be modified to return false. Doing it that way is more consistent with our current push for unobtrusive Javascript.
(In reply to comment #11) > I disagree with how the QA modification was implemented. Rather than adding > onclick attributes, the existing jQuery click handlers should be modified to > return false. Doing it that way is more consistent with our current push > for unobtrusive Javascript. Yes of course, but nodes are generated after the load of the page. So I thought it would be difficult. But in fact no, I will resubmit patches.
Created attachment 18918 [details] [review] Bug 10444 - In advanced search(more), [+] and [-] should behave like links on hover This patch add href="#" to the [+] and [-] links for adding and removing search terms. It also defines its style so it doesn't show underlined. To test: - Browse your OPAC to "Advanced Search" and then "More options". - The [+] and [-] don't change the cursor on hover - Apply the patch, reload and see the cursor changes - Functionality should remain unchanged Regards To+ Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 18919 [details] [review] Bug 10444: Fix prevent the default action on click
I'm afraid the link underlines still shows for the ccsr theme. Please add a followup to modify the ccsr css as well.
(In reply to comment #15) > I'm afraid the link underlines still shows for the ccsr theme. Please add a > followup to modify the ccsr css as well. My fault, I obsoleted it.
Created attachment 18991 [details] [review] Bug 10444 - (CCSR followup) In advanced search(more), [+] and [-] should behave like links on hover Same fix for CCSR. Regards To+ Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 18992 [details] [review] Bug 10444 - In advanced search(more), [+] and [-] should behave like links on hover This patch add href="#" to the [+] and [-] links for adding and removing search terms. It also defines its style so it doesn't show underlined. To test: - Browse your OPAC to "Advanced Search" and then "More options". - The [+] and [-] don't change the cursor on hover - Apply the patch, reload and see the cursor changes - Functionality should remain unchanged Regards To+ Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 18993 [details] [review] Bug 10444: Fix prevent the default action on click Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> So, marked as Passed QA :)
Created attachment 18997 [details] [review] Bug 10444 - In advanced search(more), [+] and [-] should behave like links on hover This patch add href="#" to the [+] and [-] links for adding and removing search terms. It also defines its style so it doesn't show underlined. To test: - Browse your OPAC to "Advanced Search" and then "More options". - The [+] and [-] don't change the cursor on hover - Apply the patch, reload and see the cursor changes - Functionality should remain unchanged Regards To+ Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Created attachment 18998 [details] [review] Bug 10444 - (CCSR followup) In advanced search(more), [+] and [-] should behave like links on hover Same fix for CCSR. Regards To+ Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Created attachment 18999 [details] [review] Bug 10444: Fix prevent the default action on click Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Pushed to master. Thanks, Tomás and Jonathan!
This patch has been pushed to 3.12.x, will be in 3.12.2. Thanks everyone!