It seems Bug 7116 has made some kind of reapparance in the order screen when ordering from existing records. If you hide subfields in your ACQ framework, these will be hidden in the item form when ordering items (AcqCreateItem = on order) but there is blank space where they used to be. This leaves the form quite long, while you want to hide fields to make it shorter and easier to handle.
Created attachment 19052 [details] screenshot
Created attachment 19237 [details] [review] Bug 10475 - Item form in acquisition not hiding subfields properly Subfields hidden in your ACQ framework leave a gap where they used to be in the item entry form when adding an item to an order. This patch makes the same change made by 7116 to services/itemrecorddisplay.tt to correct the problem. To test: - Edit your ACQ framework and set some item subfields to hidden in the editor. - Set your AcqCreateItem system preference to "when placing an order." - Add a title to an existing basket from an existing record. The item entry form should display correctly with your hidden subfields hidden. No whitespace should be left behind where the subfields were hidden. Also changed: Invalid "size" attributes on hidden form fields in neworderempty.tt, stray </li>.
Created attachment 19283 [details] [review] Bug 10475 - Item form in acquisition not hiding subfields properly Subfields hidden in your ACQ framework leave a gap where they used to be in the item entry form when adding an item to an order. This patch makes the same change made by 7116 to services/itemrecorddisplay.tt to correct the problem. To test: - Edit your ACQ framework and set some item subfields to hidden in the editor. - Set your AcqCreateItem system preference to "when placing an order." - Add a title to an existing basket from an existing record. The item entry form should display correctly with your hidden subfields hidden. No whitespace should be left behind where the subfields were hidden. Also changed: Invalid "size" attributes on hidden form fields in neworderempty.tt, stray </li>. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Created attachment 19291 [details] [review] [PASSED QA] Bug 10475 - Item form in acquisition not hiding subfields properly Subfields hidden in your ACQ framework leave a gap where they used to be in the item entry form when adding an item to an order. This patch makes the same change made by 7116 to services/itemrecorddisplay.tt to correct the problem. To test: - Edit your ACQ framework and set some item subfields to hidden in the editor. - Set your AcqCreateItem system preference to "when placing an order." - Add a title to an existing basket from an existing record. The item entry form should display correctly with your hidden subfields hidden. No whitespace should be left behind where the subfields were hidden. Also changed: Invalid "size" attributes on hidden form fields in neworderempty.tt, stray </li>. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works nicely, passes all tests and QA script. Thx Owen!
Pushed to master. Thanks, Owen!
This patch has been pushed to 3.12.x, will be in 3.12.2. Thanks Owen!
Pushed to 3.10.x, will be in 3.10.10