Bug 10484 - serials-edit.pl not checking for barcode field before checking for barcode subfield
Summary: serials-edit.pl not checking for barcode field before checking for barcode su...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Serials (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Kyle M Hall (khall)
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-17 16:28 UTC by Kyle M Hall (khall)
Modified: 2014-12-07 20:02 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 10484 - serials-edit.pl not checking for barcode field before checking for barcode subfield (1.50 KB, patch)
2013-06-17 16:28 UTC, Kyle M Hall (khall) 		Details | Diff | Splinter Review
Bug 10484 - serials-edit.pl not checking for barcode field before checking for barcode subfield (1.55 KB, patch)
2013-06-23 07:12 UTC, Chris Cormack 		Details | Diff | Splinter Review
[PASSED QA] Bug 10484 - serials-edit.pl not checking for barcode field before checking for barcode subfield (1.70 KB, patch)
2013-06-30 19:50 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall (khall) 2013-06-17 16:28:04 UTC 
The script serials-edit.pl is not checking for the existence of the barcode field before checking for barcode subfield for autoBarcode = incremental. If the barcode field doesn't exist, the script dies with errors.
Comment 1 Kyle M Hall (khall) 2013-06-17 16:28:39 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2013-06-23 07:12:48 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2013-06-30 19:50:05 UTC 
Created attachment 19304 [details] [review]
[PASSED QA] Bug 10484 - serials-edit.pl not checking for barcode field before checking for barcode subfield

The script serials-edit.pl is not checking for the existence of the
barcode field before checking for barcode subfield for autoBarcode =
incremental. If the barcode field doesn't exist, the script dies with
errors.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passes tests and QA script.
Checked that adding items on serial receive still works.
Comment 4 Galen Charlton 2013-07-01 02:03:11 UTC 
Pushed to master.  Thanks, Kyle!
Comment 5 Tomás Cohen Arazi (tcohen) 2013-07-15 18:11:12 UTC 
This patch has been pushed to 3.12.x, will be in 3.12.2.

Thanks Kyle!
Comment 6 Bernardo Gonzalez Kriegel 2013-08-02 20:20:45 UTC 
Pushed to 3.10.x, will be in 3.10.10
Comment 7 Chris Hall 2013-08-17 23:03:50 UTC 
Pushed to 3.8.x, will be in 3.8.17