Bug 10496 - CCSR theme OPAC tabs to not show correct active state
Summary: CCSR theme OPAC tabs to not show correct active state
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-20 02:49 UTC by Nicole C. Engard
Modified: 2014-12-07 20:02 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
title notes tab selected, but not highlighted (17.96 KB, image/png)
2013-06-20 02:49 UTC, Nicole C. Engard 		Details
Bug 10496 - CCSR theme OPAC tabs to not show correct active state (4.02 KB, patch)
2013-06-28 18:14 UTC, Owen Leonard 		Details | Diff | Splinter Review
[SIGNED-OFF] Bug 10496 - CCSR theme OPAC tabs to not show correct active state (4.06 KB, patch)
2013-06-28 20:23 UTC, Nicole C. Engard 		Details | Diff | Splinter Review
[SIGNED OFF] Bug 10496 - CCSR theme OPAC tabs to not show correct active state (4.42 KB, patch)
2013-06-30 08:43 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nicole C. Engard 2013-06-20 02:49:02 UTC 
Created attachment 19161 [details]
title notes tab selected, but not highlighted

In the OPAC when on the detail page the tabs in the holdings table don't have any focus in CCSR. I tested on a couple of master installs (one with custom CSS and one without).
Comment 1 Nicole C. Engard 2013-06-25 13:15:51 UTC 
It's not just the detail page but the advanced search page as well - so probably any page with tabs.
Comment 2 Owen Leonard 2013-06-28 18:14:49 UTC Comment hidden (obsolete)
Comment 3 Nicole C. Engard 2013-06-28 20:23:22 UTC Comment hidden (obsolete)
Comment 4 Katrin Fischer 2013-06-30 08:43:46 UTC 
Created attachment 19294 [details] [review]
[SIGNED OFF] Bug 10496 - CCSR theme OPAC tabs to not show correct active state

When jQueryUI was updated in the CCSR theme the corresponding CSS
changes were not copied over at the same time, causing style problems
with jQueryUI widgets. This patch makes the necessary changes.

To test, apply the patch, clear your browser cache, and view any page
which uses jQueryUI tabs (advanced search, bibliographic detail page).
Tabs should look correct and correctly show which tab is active.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
CSS changes only.
Confirmed problem in CCSR OPAC templates.
Tested advanced search and detail pages in CCSR and prog.
In order to fully test advanced search I added location and
collection to AdvancedSearchTypes.
Also tested the branch tooltip as I spotted some CSS added for that.

Works beautifully, no problems found.
Comment 5 Galen Charlton 2013-07-09 16:02:13 UTC 
Pushed to master.  Thanks, Owen!
Comment 6 Tomás Cohen Arazi (tcohen) 2013-07-16 19:01:17 UTC 
This patch has been pushed to 3.12.x, will be in 3.12.2.

Thanks Owen!