Bug 10497 - star ratings not showing right in ccsr detail
Summary: star ratings not showing right in ccsr detail
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-20 02:53 UTC by Nicole C. Engard
Modified: 2014-12-07 20:03 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
site without custom css (21.28 KB, image/png)
2013-06-20 02:53 UTC, Nicole C. Engard 		Details
site with custom css (15.28 KB, image/png)
2013-06-20 02:53 UTC, Nicole C. Engard 		Details
Bug 10497 - star ratings not showing right in ccsr detail (3.43 KB, patch)
2013-06-28 18:26 UTC, Owen Leonard 		Details | Diff | Splinter Review
[SIGNED-OFF] Bug 10497 - star ratings not showing right in ccsr detail (3.53 KB, patch)
2013-06-28 20:26 UTC, Nicole C. Engard 		Details | Diff | Splinter Review
[PASSED QA] Bug 10497 - star ratings not showing right in ccsr detail (3.77 KB, patch)
2013-06-30 08:52 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nicole C. Engard 2013-06-20 02:53:11 UTC 
Created attachment 19162 [details]
site without custom css

On the detail page in ccsr the star ratings are either showing as radio buttons (on my custom css) or as nothing at all (on my site without custom css).
Comment 1 Nicole C. Engard 2013-06-20 02:53:29 UTC 
Created attachment 19163 [details]
site with custom css
Comment 2 Ed Veal 2013-06-20 12:23:52 UTC 
This is also an issue with the results page. I checked the code and the star on the results page is not showing because it is looking for "../../images/star-ratings-sprite.png" and the image is not present there. 

Regarding the details page and the start rating. It appears that there is no css for the ratings for the ccsr theme.

Ed
Comment 3 Owen Leonard 2013-06-28 18:26:27 UTC Comment hidden (obsolete)
Comment 4 Nicole C. Engard 2013-06-28 20:26:22 UTC Comment hidden (obsolete)
Comment 5 Katrin Fischer 2013-06-30 08:45:44 UTC 
Hi Nicole, please remember to tick the 'patch' checkbox when uploading a patch manually.
Comment 6 Katrin Fischer 2013-06-30 08:52:21 UTC 
Created attachment 19295 [details] [review]
[PASSED QA] Bug 10497 - star ratings not showing right in ccsr detail

Star ratings do not appear correctly in the CCSR theme because it lacks
the image sprite used to display them. This patch adds the required
file.

To test, apply the patch and view a search results set which includes
titles which have an existing rating. Ratings should appear correctly.

View a detail page for an title which has a rating, and add a rating to
a title which has no rating. Ratings should look correct and work
correctly.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
All tests pass - including leaving a rating on the newly visible stars

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
In order to test this, make sure you have set OpacStarRatings set
to 'results and details'.

The star images show up in OPAC results with the correct amount
of stars after applying the patch.
Comment 7 Galen Charlton 2013-07-01 02:14:51 UTC 
Pushed to master.  Thanks, Owen!
Comment 8 Tomás Cohen Arazi (tcohen) 2013-07-15 23:40:37 UTC 
This patch has been pushed to 3.12.x, will be in 3.12.2.

Thanks Owen!
Comment 9 Bernardo Gonzalez Kriegel 2013-08-02 20:22:26 UTC 
Pushed to 3.10.x, will be in 3.10.10
Comment 10 Chris Hall 2013-08-17 23:08:19 UTC 
Pushed to 3.8.x, will be in 3.8.17