An error in the onclick for phone notices causes the "Do not notify" checkbox to be checked when the phone checkbox is checked. Also, checking "Do not notify" does not uncheck the phone checkbox.
Created attachment 19252 [details] [review] Bug 10511 - Odd behavior for messaging preferences with Talking Tech enabled An error in the onclick for phone notices causes the "Do not notify" checkbox to be checked when the phone checkbox is checked. Also, checking "Do not notify" does not uncheck the phone checkbox. Test plan: 1) Enable TalkingTechItivaPhoneNotification 2) Browse to the new patron screen ( memberentry.pl ) 3) In the patron messaging preferences check the Phone checkbox 4) Not the "do not notify" checkbox is then checked 5) Uncheck the "do not notify" checkbox, and check the Email checkbox as well 6) Now check the "do not notify" checkbox, note the Phone checkbox remains checked 7) Apply this patch 8) Repeat steps 3-6, noting the odd behavior is no longer present
Created attachment 19783 [details] [review] [SIGNED-OFF] Bug 10511 - Odd behavior for messaging preferences with Talking Tech enabled An error in the onclick for phone notices causes the "Do not notify" checkbox to be checked when the phone checkbox is checked. Also, checking "Do not notify" does not uncheck the phone checkbox. Test plan: 1) Enable TalkingTechItivaPhoneNotification 2) Browse to the new patron screen ( memberentry.pl ) 3) In the patron messaging preferences check the Phone checkbox 4) Not the "do not notify" checkbox is then checked 5) Uncheck the "do not notify" checkbox, and check the Email checkbox as well 6) Now check the "do not notify" checkbox, note the Phone checkbox remains checked 7) Apply this patch 8) Repeat steps 3-6, noting the odd behavior is no longer present Signed-off-by: Srdjan <srdjan@catalyst.net.nz>
QA comment: removeAttr takes only 1 parameter. Marked as Failed QA.
Created attachment 19850 [details] [review] Bug 10511 - Odd behavior for messaging preferences with Talking Tech enabled - QA Followup
QA comment: The described ergonomic issue has been fixed. Marked as Passed QA.
Created attachment 20271 [details] [review] Bug 10511 - Odd behavior for messaging preferences with Talking Tech enabled An error in the onclick for phone notices causes the "Do not notify" checkbox to be checked when the phone checkbox is checked. Also, checking "Do not notify" does not uncheck the phone checkbox. Test plan: 1) Enable TalkingTechItivaPhoneNotification 2) Browse to the new patron screen ( memberentry.pl ) 3) In the patron messaging preferences check the Phone checkbox 4) Not the "do not notify" checkbox is then checked 5) Uncheck the "do not notify" checkbox, and check the Email checkbox as well 6) Now check the "do not notify" checkbox, note the Phone checkbox remains checked 7) Apply this patch 8) Repeat steps 3-6, noting the odd behavior is no longer present Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Created attachment 20272 [details] [review] Bug 10511 - Odd behavior for messaging preferences with Talking Tech enabled - QA Followup Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Pushed to master. Thanks, Kyle!
This patch has been pushed to 3.12.x, will be in 3.12.5. Thanks Kyle!
Pushed to 3.10.x, will be in 3.10.11