Bug 10515 - The prototype for GetBranchCategory and GetBranchCategories is not consistent
Summary: The prototype for GetBranchCategory and GetBranchCategories is not consistent
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Jonathan Druart
QA Contact:
URL:
Keywords:
Depends on:
Blocks: 10508
  Show dependency treegraph
 
Reported: 2013-06-28 14:13 UTC by Jonathan Druart
Modified: 2014-12-07 20:02 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 10515: The prototype for GetBranchCategory and GetBranchCategories is not consistent (9.76 KB, patch)
2013-06-28 14:14 UTC, Jonathan Druart
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 10515: The prototype for GetBranchCategory and GetBranchCategories is not consistent (9.81 KB, patch)
2013-07-11 01:58 UTC, Srdjan Jankovic
Details | Diff | Splinter Review
Bug 10515: The prototype for GetBranchCategory and GetBranchCategories is not consistent (9.86 KB, patch)
2013-07-12 14:33 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2013-06-28 14:13:36 UTC
The prototype is not consistent, GetBranchCategory should return only 1 result and GetBranchCategories should not have a categorycode argument.
Comment 1 Jonathan Druart 2013-06-28 14:14:36 UTC Comment hidden (obsolete)
Comment 2 Srdjan Jankovic 2013-07-11 01:58:06 UTC Comment hidden (obsolete)
Comment 3 Kyle M Hall 2013-07-12 14:33:44 UTC
Created attachment 19597 [details] [review]
Bug 10515: The prototype for GetBranchCategory and GetBranchCategories is not consistent

The prototype is not consistent, GetBranchCategory should return only 1 result
and GetBranchCategories should not have a categorycode argument.
This patch fixes that.

Test plan:
1/ Try to add/remove/modify a library.
2/ Add some groups
3/ Add these groups to a library

Signed-off-by: Srdjan <srdjan@catalyst.net.nz>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Passes koha-qa.pl, works as advertised.
Comment 4 Galen Charlton 2013-07-17 18:04:55 UTC
Pushed to master, along with two follow-ups to add a regression test and to fix the call to GetBranchCategories in C4/Auth.pm.
Comment 5 Tomás Cohen Arazi 2013-08-13 16:46:24 UTC
This patch (along with Galen's regression tests) has been pushed to 3.12.x, will be in 3.12.4.

Thanks Jonathan!