The template for adding and updating a Z39.50 server currently shows the same message for adds and updates. It would be more clear if it showed one message for adds and one for updates.
Created attachment 19807 [details] [review] Bug 10516 - Improve titles, breadcrumbs, and confirmation messages for Z39.50 server adds and updates The template for adding/editing Z39.50 servers shows the same title, breadcrumbs, etc. for add and edit operations. This patch creates separate text for each case. To test, try both adding and editing a Z39.50 server. The page title, breadcrumb, and heading should correctly reflect the operation you perform.
Created attachment 19812 [details] [review] Bug 10516 - Improve titles, breadcrumbs, and confirmation messages for Z39.50 server adds and updates The template for adding/editing Z39.50 servers shows the same title, breadcrumbs, etc. for add and edit operations. This patch creates separate text for each case. To test, try both adding and editing a Z39.50 server. The page title, breadcrumb, and heading should correctly reflect the operation you perform. Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Created attachment 19832 [details] [review] [PASSED QA] Bug 10516 - Improve titles, breadcrumbs, and confirmation messages for Z39.50 server adds and updates The template for adding/editing Z39.50 servers shows the same title, breadcrumbs, etc. for add and edit operations. This patch creates separate text for each case. To test, try both adding and editing a Z39.50 server. The page title, breadcrumb, and heading should correctly reflect the operation you perform. Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works nicely and all strings are translatable.
Created attachment 19833 [details] [review] Bug 10516 - Follow up - Fixing capitalization Fix capitalization on submit buttons when deleting a Z39.50 server. - Delete this Server - Do Not Delete I think the "Do not delete" should maybe even be a cancel link to be more consistent with how Koha displays this kind of dialog in other places.
Created attachment 19842 [details] [review] Bug 10516 - Follow up - Fixing capitalization Fix capitalization on submit buttons when deleting a Z39.50 server. - Delete this Server - Do Not Delete I think the "Do not delete" should maybe even be a cancel link to be more consistent with how Koha displays this kind of dialog in other places. Signed-off-by: Liz Rea <wizzyrea@gmail.com> fixes capitalisation, tool stil works
Thx Liz!
Switching back to passed QA after checking with Galen.
(In reply to Liz Rea from comment #5) > I think the "Do not delete" should maybe even be a cancel > link to be more consistent with how Koha displays this > kind of dialog in other places. I agree, but I'm content to leave that to a follow-up.
Pushed to master. Thanks, Owen!
This patch has been pushed to 3.12.x, will be in 3.12.4. Thanks Owen!
Pushed to 3.10.x, will be in 3.10.11
Pushed to 3.8.x, will be in 3.8.18
*** Bug 9849 has been marked as a duplicate of this bug. ***