Bug 10520 - Add i18n function to English mysql files for webinstaller
Summary: Add i18n function to English mysql files for webinstaller
Status: CLOSED WONTFIX
Alias: None
Product: Koha
Classification: Unclassified
Component: Installation and upgrade (web-based installer) (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Marcel de Rooy
QA Contact:
URL:
Keywords:
Depends on: 10509
Blocks: 10521 10526 10572
  Show dependency treegraph
 
Reported: 2013-07-01 10:47 UTC by Marcel de Rooy
Modified: 2014-12-07 20:02 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 10520: Add i18n function to en/mandatory mysql files (104.91 KB, patch)
2013-07-06 12:00 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 10520: Add i18n function to en/optional mysql files (158.64 KB, patch)
2013-07-06 12:57 UTC, Marcel de Rooy
Details | Diff | Splinter Review
[PATCH_IN_GZIP] Bug 10520: Add i18n function to en/marflavour mysql files (800.79 KB, text/plain)
2013-07-11 06:41 UTC, Marcel de Rooy
Details
Bug 10520: Add i18n function to en/mandatory mysql files (104.92 KB, patch)
2013-08-02 17:58 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 10520: Add i18n function to en/optional mysql files (158.66 KB, patch)
2013-08-02 17:58 UTC, Kyle M Hall
Details | Diff | Splinter Review
[PATCH_IN_GZIP] Bug 10520: Add i18n function to en/marflavour mysql files (800.84 KB, application/gzip)
2013-08-02 18:03 UTC, Kyle M Hall
Details
Bug 10520: Add i18n function to en/optional mysql files (158.70 KB, patch)
2013-09-16 11:43 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2013-07-01 10:47:59 UTC
See bug 10590.
This bug is a followup to convert the English files to the new style using the i18n function.
This function translates the strings for the non-English languages.
Comment 1 Marcel de Rooy 2013-07-06 12:00:43 UTC Comment hidden (obsolete)
Comment 2 Marcel de Rooy 2013-07-06 12:57:26 UTC Comment hidden (obsolete)
Comment 3 Marcel de Rooy 2013-07-06 13:02:33 UTC
The first two patches are ready for signoff.
The last patch should cover all files in marcflavour section.
I still wait a few days in the hope to catch all MARC21 changes too from Bernardo in bug 5858.
Comment 4 Marcel de Rooy 2013-07-06 13:05:38 UTC
Just to be clear: last patch refers to the third patch not yet attached :)
Comment 5 Chris Cormack 2013-07-06 19:00:13 UTC
Marcel should I wait for all 3 before signing off?
Comment 6 Marcel de Rooy 2013-07-07 11:23:52 UTC
Chris: Thanks for testing. You are welcome to sign off what is available..
Comment 7 Marcel de Rooy 2013-07-11 06:41:36 UTC Comment hidden (obsolete)
Comment 8 Marcel de Rooy 2013-07-11 06:54:01 UTC
The size of the simple_bib file and its 'redundant' contents would almost make me split it up in multiple files. It would be even nicer if we could do an insert..select for the marc structure and just update the status column on the tags/subfields to make them visible or hidden in the several frameworks.
Comment 9 Kyle M Hall 2013-08-02 17:58:16 UTC
Created attachment 20078 [details] [review]
Bug 10520: Add i18n function to en/mandatory mysql files

Main goal: Adds i18n calls around translatable columns.
Additionally: Removes backtics.
Adds column names in inserts (where missing).
Uses consistent style (based on my interpretation of coding guidelines).

Test plan:
Make sure that you apply this patch on top of the 10509 patches!
Run English mysql install.
Verify that you include all mandatory files.
Check if webinstaller does not report errors.
Inspect table contents via interface or mysql.
Search for a column not using i18n where you would expect translation.

Note: If you prefer to run the mysql files from command line, please make sure
now that you define a 'fake' i18n, doing nothing (see Installer.pm code).

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Tested both ways myself.
Noticed that I missed one message_transport_type (phone) and one language
description (180 vs. 181). If needed, will handle these on a separate report.
They do not directly relate to this patch.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 10 Kyle M Hall 2013-08-02 17:58:55 UTC Comment hidden (obsolete)
Comment 11 Kyle M Hall 2013-08-02 18:03:39 UTC Comment hidden (obsolete)
Comment 12 Katrin Fischer 2013-09-12 20:28:42 UTC
Depends on bug 10509 that doesn't apply - moving to blocked for now.
Comment 13 Marcel de Rooy 2013-09-16 11:43:03 UTC
Created attachment 21118 [details] [review]
Bug 10520: Add i18n function to en/optional mysql files

Main goal: Adds i18n calls around translatable columns.
Additionally: Removes backtics.
Adds column names in inserts (where missing).
Uses consistent style (based on my interpretation of coding guidelines).
Removed some locking statements in sample_creator_data.
NOTE: Some scripts insert numbers in auto-increment columns. Although this
works, I would not prefer to do so.
This patch however is not meant to change that, so leaves them for now.

Test plan:
Make sure that you apply this patch on top of the 10509 patches!
Run English mysql install.
Verify that you include all OPTIONAL files (in the OTHER DATA section).
Check if webinstaller does not report errors.
Inspect table contents via interface or mysql.
Search for a column not using i18n where you would expect translation.

Note: If you prefer to run the mysql files from command line, please make sure
now that you define a 'fake' i18n, doing nothing (see Installer.pm code).

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Tested all optional data via webinstaller.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 14 Marcel de Rooy 2013-09-16 11:43:48 UTC
Rebased for trivial withdrawn change in auth_val.sql
Comment 15 Marcel de Rooy 2013-09-16 11:57:10 UTC
The third patch for marcflavour is huge and does not apply anymore. It was signed by Kyle.
Please let me know if you want to start QA on that file; I will rebase it then.

Back to Signed off.
Comment 16 Magnus Enger 2014-02-12 06:24:22 UTC
Marcel: The status is now RESOLVED WONTFIX - is that a mistake?
Comment 17 Marcel de Rooy 2014-02-12 12:02:13 UTC
(In reply to Magnus Enger from comment #16)
> Marcel: The status is now RESOLVED WONTFIX - is that a mistake?

No. I gave up on this report. No support..