See bug 10590. This bug is a followup to convert the English files to the new style using the i18n function. This function translates the strings for the non-English languages.
Created attachment 19439 [details] [review] Bug 10520: Add i18n function to en/mandatory mysql files Main goal: Adds i18n calls around translatable columns. Additionally: Removes backtics. Adds column names in inserts (where missing). Uses consistent style (based on my interpretation of coding guidelines). Test plan: Make sure that you apply this patch on top of the 10509 patches! Run English mysql install. Verify that you include all mandatory files. Check if webinstaller does not report errors. Inspect table contents via interface or mysql. Search for a column not using i18n where you would expect translation. Note: If you prefer to run the mysql files from command line, please make sure now that you define a 'fake' i18n, doing nothing (see Installer.pm code). Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Tested both ways myself. Noticed that I missed one message_transport_type (phone) and one language description (180 vs. 181). If needed, will handle these on a separate report. They do not directly relate to this patch.
Created attachment 19440 [details] [review] Bug 10520: Add i18n function to en/optional mysql files Main goal: Adds i18n calls around translatable columns. Additionally: Removes backtics. Adds column names in inserts (where missing). Uses consistent style (based on my interpretation of coding guidelines). Removed some locking statements in sample_creator_data. NOTE: Some scripts insert numbers in auto-increment columns. Although this works, I would not prefer to do so. This patch however is not meant to change that, so leaves them for now. Test plan: Make sure that you apply this patch on top of the 10509 patches! Run English mysql install. Verify that you include all OPTIONAL files (in the OTHER DATA section). Check if webinstaller does not report errors. Inspect table contents via interface or mysql. Search for a column not using i18n where you would expect translation. Note: If you prefer to run the mysql files from command line, please make sure now that you define a 'fake' i18n, doing nothing (see Installer.pm code). Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Tested all optional data via webinstaller.
The first two patches are ready for signoff. The last patch should cover all files in marcflavour section. I still wait a few days in the hope to catch all MARC21 changes too from Bernardo in bug 5858.
Just to be clear: last patch refers to the third patch not yet attached :)
Marcel should I wait for all 3 before signing off?
Chris: Thanks for testing. You are welcome to sign off what is available..
Created attachment 19542 [details] [PATCH_IN_GZIP] Bug 10520: Add i18n function to en/marflavour mysql files IMPORTANT: Patch file is too big for git-bz. Please download this .gz and unzip the patch file to apply it manually. Thank you.
The size of the simple_bib file and its 'redundant' contents would almost make me split it up in multiple files. It would be even nicer if we could do an insert..select for the marc structure and just update the status column on the tags/subfields to make them visible or hidden in the several frameworks.
Created attachment 20078 [details] [review] Bug 10520: Add i18n function to en/mandatory mysql files Main goal: Adds i18n calls around translatable columns. Additionally: Removes backtics. Adds column names in inserts (where missing). Uses consistent style (based on my interpretation of coding guidelines). Test plan: Make sure that you apply this patch on top of the 10509 patches! Run English mysql install. Verify that you include all mandatory files. Check if webinstaller does not report errors. Inspect table contents via interface or mysql. Search for a column not using i18n where you would expect translation. Note: If you prefer to run the mysql files from command line, please make sure now that you define a 'fake' i18n, doing nothing (see Installer.pm code). Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Tested both ways myself. Noticed that I missed one message_transport_type (phone) and one language description (180 vs. 181). If needed, will handle these on a separate report. They do not directly relate to this patch. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 20079 [details] [review] Bug 10520: Add i18n function to en/optional mysql files Main goal: Adds i18n calls around translatable columns. Additionally: Removes backtics. Adds column names in inserts (where missing). Uses consistent style (based on my interpretation of coding guidelines). Removed some locking statements in sample_creator_data. NOTE: Some scripts insert numbers in auto-increment columns. Although this works, I would not prefer to do so. This patch however is not meant to change that, so leaves them for now. Test plan: Make sure that you apply this patch on top of the 10509 patches! Run English mysql install. Verify that you include all OPTIONAL files (in the OTHER DATA section). Check if webinstaller does not report errors. Inspect table contents via interface or mysql. Search for a column not using i18n where you would expect translation. Note: If you prefer to run the mysql files from command line, please make sure now that you define a 'fake' i18n, doing nothing (see Installer.pm code). Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Tested all optional data via webinstaller. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 20080 [details] [PATCH_IN_GZIP] Bug 10520: Add i18n function to en/marflavour mysql files
Depends on bug 10509 that doesn't apply - moving to blocked for now.
Created attachment 21118 [details] [review] Bug 10520: Add i18n function to en/optional mysql files Main goal: Adds i18n calls around translatable columns. Additionally: Removes backtics. Adds column names in inserts (where missing). Uses consistent style (based on my interpretation of coding guidelines). Removed some locking statements in sample_creator_data. NOTE: Some scripts insert numbers in auto-increment columns. Although this works, I would not prefer to do so. This patch however is not meant to change that, so leaves them for now. Test plan: Make sure that you apply this patch on top of the 10509 patches! Run English mysql install. Verify that you include all OPTIONAL files (in the OTHER DATA section). Check if webinstaller does not report errors. Inspect table contents via interface or mysql. Search for a column not using i18n where you would expect translation. Note: If you prefer to run the mysql files from command line, please make sure now that you define a 'fake' i18n, doing nothing (see Installer.pm code). Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Tested all optional data via webinstaller. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Rebased for trivial withdrawn change in auth_val.sql
The third patch for marcflavour is huge and does not apply anymore. It was signed by Kyle. Please let me know if you want to start QA on that file; I will rebase it then. Back to Signed off.
Marcel: The status is now RESOLVED WONTFIX - is that a mistake?
(In reply to Magnus Enger from comment #16) > Marcel: The status is now RESOLVED WONTFIX - is that a mistake? No. I gave up on this report. No support..