Created attachment 19314 [details] [review] Bug 10523: Remove two obsolete routines from Installer.pm The routines sql_file_list and marcflavour_list in Installer.pm are not used. There are some references to them in probably obsolete '/lib' test units. I changed these test units for the record too. Also: removed the not-existing marcflavour parameter of sample_data_sql_list in its call in install.pl. Test plan: Run a new install.
There could be a small clash with bug 10509 in a POD section. Easy conflict to resolve. Does not really matter which bug goes first. (This is the easy one)
Created attachment 19323 [details] [review] Bug 10523: Remove two obsolete routines from Installer.pm The routines sql_file_list and marcflavour_list in Installer.pm are not used. There are some references to them in probably obsolete '/lib' test units. I changed these test units for the record too. Also: removed the not-existing marcflavour parameter of sample_data_sql_list in its call in install.pl. Test plan: Run a new install.
Created attachment 21012 [details] [review] this is the patch after rebasing it. I also signed off it
I rebased the patch after deleting three *.pm from test section, because the corresponding *.pm modules were already deleted in HEAD. I removed from the patch the following *.pm: t/db_dependent/lib/KohaTest/Installer/SqlScripts.pm t/db_dependent/lib/KohaTest/Installer.pm t/db_dependent/lib/KohaTest.pm Then I signed off the rebased patch.
Created attachment 21013 [details] [review] Bug 10523: Remove two obsolete routines from Installer.pm
Created attachment 21015 [details] [review] Bug 10523: Remove two obsolete routines from Installer.pm The routines sql_file_list and marcflavour_list in Installer.pm are not used. There are some references to them in probably obsolete '/lib' test units. I changed these test units for the record too. Also: removed the not-existing marcflavour parameter of sample_data_sql_list in its call in install.pl. Test plan: Run a new install. Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 21016 [details] [review] Bug 10523: QA Followup - Remove unused variable Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Thanks for QA, Kyle. But I am not sure about the qa followup. It is just theoretical, because it only touches lines in pod section. But load_sql_in_order still needs a second parameter. So I think you should not remove it. Can we do without the second patch?
Comment on attachment 21016 [details] [review] Bug 10523: QA Followup - Remove unused variable Obsoleting this patch in light of the earlier comment.
Pushed to master. Thanks, Marcel!