Bug 10523 - Remove two obsolete routines from Installer.pm
Summary: Remove two obsolete routines from Installer.pm
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Installation and upgrade (web-based installer) (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Marcel de Rooy
QA Contact: Kyle M Hall
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-01 13:22 UTC by Marcel de Rooy
Modified: 2014-05-26 21:04 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 10523: Remove two obsolete routines from Installer.pm (7.26 KB, patch)
2013-07-01 13:29 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 10523: Remove two obsolete routines from Installer.pm (7.28 KB, patch)
2013-07-01 15:48 UTC, Marcel de Rooy
Details | Diff | Splinter Review
this is the patch after rebasing it. I also signed off it (4.03 KB, patch)
2013-09-12 12:16 UTC, Paola Rossi
Details | Diff | Splinter Review
Bug 10523: Remove two obsolete routines from Installer.pm (4.03 KB, patch)
2013-09-12 12:28 UTC, Paola Rossi
Details | Diff | Splinter Review
Bug 10523: Remove two obsolete routines from Installer.pm (4.08 KB, patch)
2013-09-12 13:03 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 10523: QA Followup - Remove unused variable (960 bytes, patch)
2013-09-12 13:03 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2013-07-01 13:22:06 UTC

    
Comment 1 Marcel de Rooy 2013-07-01 13:29:00 UTC Comment hidden (obsolete)
Comment 2 Marcel de Rooy 2013-07-01 13:33:07 UTC
There could be a small clash with bug 10509 in a POD section. Easy conflict to resolve. Does not really matter which bug goes first. (This is the easy one)
Comment 3 Marcel de Rooy 2013-07-01 15:48:07 UTC Comment hidden (obsolete)
Comment 4 Paola Rossi 2013-09-12 12:16:28 UTC Comment hidden (obsolete)
Comment 5 Paola Rossi 2013-09-12 12:22:21 UTC
I rebased the patch after deleting three *.pm from test section, because the corresponding *.pm modules were already deleted in HEAD. 
I removed from the patch the following *.pm:
t/db_dependent/lib/KohaTest/Installer/SqlScripts.pm
t/db_dependent/lib/KohaTest/Installer.pm
t/db_dependent/lib/KohaTest.pm
Then I signed off the rebased patch.
Comment 6 Paola Rossi 2013-09-12 12:28:00 UTC Comment hidden (obsolete)
Comment 7 Kyle M Hall 2013-09-12 13:03:05 UTC
Created attachment 21015 [details] [review]
Bug 10523: Remove two obsolete routines from Installer.pm

The routines sql_file_list and marcflavour_list in Installer.pm are not used.
There are some references to them in probably obsolete '/lib' test units.
I changed these test units for the record too.

Also: removed the not-existing marcflavour parameter of sample_data_sql_list
in its call in install.pl.

Test plan:
Run a new install.

Signed-off-by: Paola Rossi <paola.rossi@cineca.it>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 8 Kyle M Hall 2013-09-12 13:03:14 UTC Comment hidden (obsolete)
Comment 9 Marcel de Rooy 2013-09-19 13:31:26 UTC
Thanks for QA, Kyle.
But I am not sure about the qa followup.
It is just theoretical, because it only touches lines in pod section.
But load_sql_in_order still needs a second parameter.
So I think you should not remove it. Can we do without the second patch?
Comment 10 Marcel de Rooy 2013-10-31 11:02:03 UTC
Comment on attachment 21016 [details] [review]
Bug 10523: QA Followup - Remove unused variable

Obsoleting this patch in light of the earlier comment.
Comment 11 Galen Charlton 2013-10-31 16:52:10 UTC
Pushed to master.  Thanks, Marcel!