The routine patronflags in C4::Members sets messages if patron owes or is credited with an amount of money. Unfortunately for those of us not using dollars as our currency. The amounts appearing in these messages is hardcoded to be preceded by $ it should be more sensitive to the configuration. One of the places this message is displayed is on self issue machines, which being public facing cause libraries some embarrasment
Created attachment 19396 [details] [review] Proposed Patch My original patch, which has been tested in production used the currency symbol. However looking for a non-SIP usage of the message field to put in testplan, I realized that in the patron screens we consistently omit the currency symbol from money amounts, so this version is consistent with that practice. To test using a sip device issue a patron information request (63) for a patron owing fines. Without this patch the response will include in the screen message 'Patron owes $6.00' with this patch applied it returns 'Patron owes 6.00'
Created attachment 19445 [details] [review] Bug 10529: Remove hardcoded dollar from patron message The message fields which are returned in the SIP Screen message field in a Patron Information response had dollar hardcoded. It would be possible to get the symbol from currency but omitting any symbol would be consistent with the UI and avoid problems with devices using weird encodings for local currency symbols (e.g. the many variations of UK Pound sign) Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Created attachment 19609 [details] [review] Bug 10529: Remove hardcoded dollar from patron message The message fields which are returned in the SIP Screen message field in a Patron Information response had dollar hardcoded. It would be possible to get the symbol from currency but omitting any symbol would be consistent with the UI and avoid problems with devices using weird encodings for local currency symbols (e.g. the many variations of UK Pound sign) Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Pushed to master. Thanks, Colin!
This patch has been pushed to 3.12.x, will be in 3.12.2. Thanks Colin!
This does not apply cleanly to 3.10.x, please submit one formatted for 3.10.x.