Bug 10535 - by default sort funds by name
Summary: by default sort funds by name
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Fridolin Somers
QA Contact:
URL:
Keywords:
Depends on: 10577
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-03 12:23 UTC by Fridolin Somers
Modified: 2015-06-04 23:23 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Proposed patch (1.21 KB, patch)
2013-07-03 12:29 UTC, Fridolin Somers
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 10535 - by default sort funds by name (1.26 KB, patch)
2013-07-05 12:39 UTC, Fridolin Somers
Details | Diff | Splinter Review
[PASSED QA] Bug 10535 - by default sort funds by name (1.47 KB, patch)
2013-07-11 06:10 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 10535: (follow-up) add test case (1.77 KB, patch)
2013-07-11 16:55 UTC, Galen Charlton
Details | Diff | Splinter Review
Bug 10535: (follow-up) add test case (1.83 KB, patch)
2013-08-22 14:25 UTC, Jared Camins-Esakov
Details | Diff | Splinter Review
Bug 10535: (follow-up) add test case (1.89 KB, patch)
2013-08-23 08:37 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Fridolin Somers 2013-07-03 12:23:50 UTC
In parcels.pl, and other acquisition pages, the funds are not sorted by name in combo-box.
With a great number of founds, it is difficult to find one.
Comment 1 Fridolin Somers 2013-07-03 12:29:49 UTC Comment hidden (obsolete)
Comment 2 Paul Poulain 2013-07-04 09:16:11 UTC
Patch tested with a sandbox, by Silvia Simonetti <s.simonetti@cineca.it>
Comment 3 Fridolin Somers 2013-07-05 12:39:56 UTC Comment hidden (obsolete)
Comment 4 Katrin Fischer 2013-07-11 06:10:28 UTC Comment hidden (obsolete)
Comment 5 Galen Charlton 2013-07-11 16:53:15 UTC
Pushed to master.  Thanks, Fridoyn!
Comment 6 Galen Charlton 2013-07-11 16:55:10 UTC Comment hidden (obsolete)
Comment 7 Galen Charlton 2013-07-11 16:57:20 UTC
I've attached a follow-up patch that adds a test case for the change to the default sort order.  I very much prefer that *all* changes to routines in C4 and Koha be accompanied by test cases.

Note that in order for this patch to apply cleanly, the patch for bug 10577 must be applied first.
Comment 8 Tomás Cohen Arazi 2013-07-16 19:07:10 UTC
The first patch has been pushed to 3.12.x, will be in 3.12.2.

Thanks Fridolyn!
Comment 9 David Cook 2013-07-18 06:29:28 UTC
(In reply to Galen Charlton from comment #7)
> I've attached a follow-up patch that adds a test case for the change to the
> default sort order.  I very much prefer that *all* changes to routines in C4
> and Koha be accompanied by test cases.
> 
> Note that in order for this patch to apply cleanly, the patch for bug 10577
> must be applied first.

I applied 10577, then 10535, ran the test, and all looked good.

Since 10577 has failed QA, what's the proper process now? Wait until 10577 passes QA or is pushed?
Comment 10 Bernardo Gonzalez Kriegel 2013-08-04 19:56:16 UTC
First patch pushed to 3.10.x, will be in 3.10.10
Comment 11 Chris Hall 2013-08-18 04:51:06 UTC
First patch pushed to 3.8.x, will be in 3.8.17
Comment 12 Jared Camins-Esakov 2013-08-22 14:25:55 UTC Comment hidden (obsolete)
Comment 13 Jonathan Druart 2013-08-23 08:37:46 UTC
Created attachment 20579 [details] [review]
Bug 10535: (follow-up) add test case

This adds a test case for the new default sort
order for GetBudgets().

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 14 Galen Charlton 2013-10-17 23:07:36 UTC
Follow-up pushed to master.
Comment 15 Tomás Cohen Arazi 2013-12-03 18:10:35 UTC
Follow-up pushed to 3.12.x, will be in 3.12.8.

Thanks Galen!