$ cd kohaclone $ ./koha-perl-deps.pl -m -u Installed Required Module is Module Name Version Version Required -------------------------------------------------------------------------------------------- Data::Pagination 0 * 0.44 No Archive::Extract 0.48 * 0.60 No Test::WWW::Mechanize 1.36 * 1.44 No -------------------------------------------------------------------------------------------- Total modules reported: 3 * Module is missing or requires an upgrade. $ ./koha-perl-deps.pl -m -u -r Installed Required Module is Module Name Version Version Required -------------------------------------------------------------------------------------------- -------------------------------------------------------------------------------------------- Total modules reported: 3 * Module is missing or requires an upgrade. The second number should be 0. This tiny patch fixes it.
Created attachment 19442 [details] [review] Moved $count++ into if statements to fix miscount. TEST ----- $ cd kohaclone $ ./koha_perl_deps.pl -m -u if you have nothing missing, uninstall an optional component. $ ./koha_perl_deps.pl -m -u you should get a number missing of at least 1. $ ./koha_perl_deps.pl -m -u -r you should get the same number, even though the output is less. apply patch $ ./koha_perl_deps.pl -m -u same results $ ./koha_perl_deps.pl -m -u -r the number should differ.
Created attachment 19524 [details] [review] bug 10548: fix count of missing required dependencies by koha_perl_deps.pl To test: [1] ./koha_perl_deps.pl -m -u If you have nothing missing, uninstall an optional component. [2] ./koha_perl_deps.pl -m -u You should get a number missing of at least 1. [3] ./koha_perl_deps.pl -m -u -r You should get the same number, even though the output is less. [4] Apply patch [5] ./koha_perl_deps.pl -m -u Same results as in step 2. [6] ./koha_perl_deps.pl -m -u -r The number should differ from the results in step 3. Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Created attachment 19568 [details] [review] bug 10548: fix count of missing required dependencies by koha_perl_deps.pl To test: [1] ./koha_perl_deps.pl -m -u If you have nothing missing, uninstall an optional component. [2] ./koha_perl_deps.pl -m -u You should get a number missing of at least 1. [3] ./koha_perl_deps.pl -m -u -r You should get the same number, even though the output is less. [4] Apply patch [5] ./koha_perl_deps.pl -m -u Same results as in step 2. [6] ./koha_perl_deps.pl -m -u -r The number should differ from the results in step 3. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
QA Comment: Tiny patch. Looks good to me. Passed QA
Pushed to master. Thanks, Mark!
This patch has been pushed to 3.12.x, will be in 3.12.2. Thanks Mark!
Pushed to 3.10.x, will be in 3.10.10