Bug 10548 - koha_perl_deps.pl miscounts dependencies displayed
Summary: koha_perl_deps.pl miscounts dependencies displayed
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Installation and upgrade (command-line installer) (show other bugs)
Version: master
Hardware: All All
: P5 - low trivial (vote)
Assignee: Mark Tompsett
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-06 19:48 UTC by Mark Tompsett
Modified: 2014-12-07 20:02 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Moved $count++ into if statements to fix miscount. (1.47 KB, patch)
2013-07-06 19:56 UTC, Mark Tompsett
Details | Diff | Splinter Review
bug 10548: fix count of missing required dependencies by koha_perl_deps.pl (1.87 KB, patch)
2013-07-10 15:50 UTC, Galen Charlton
Details | Diff | Splinter Review
bug 10548: fix count of missing required dependencies by koha_perl_deps.pl (1.96 KB, patch)
2013-07-11 13:34 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Tompsett 2013-07-06 19:48:23 UTC
$ cd kohaclone
$ ./koha-perl-deps.pl -m -u

                                              Installed         Required          Module is
Module Name                                   Version           Version            Required
--------------------------------------------------------------------------------------------
Data::Pagination                              0 *               0.44                    No
Archive::Extract                              0.48 *            0.60                    No
Test::WWW::Mechanize                          1.36 *            1.44                    No

--------------------------------------------------------------------------------------------
Total modules reported: 3                      * Module is missing or requires an upgrade.
$ ./koha-perl-deps.pl -m -u -r

                                              Installed         Required          Module is
Module Name                                   Version           Version            Required
--------------------------------------------------------------------------------------------

--------------------------------------------------------------------------------------------
Total modules reported: 3                      * Module is missing or requires an upgrade.

The second number should be 0. This tiny patch fixes it.
Comment 1 Mark Tompsett 2013-07-06 19:56:14 UTC Comment hidden (obsolete)
Comment 2 Galen Charlton 2013-07-10 15:50:52 UTC Comment hidden (obsolete)
Comment 3 Marcel de Rooy 2013-07-11 13:34:52 UTC
Created attachment 19568 [details] [review]
bug 10548: fix count of missing required dependencies by koha_perl_deps.pl

To test:

[1] ./koha_perl_deps.pl -m -u

If you have nothing missing, uninstall an optional component.

[2] ./koha_perl_deps.pl -m -u

You should get a number missing of at least 1.

[3] ./koha_perl_deps.pl -m -u -r

You should get the same number, even though the output is less.

[4] Apply patch

[5] ./koha_perl_deps.pl -m -u

Same results as in step 2.

[6] ./koha_perl_deps.pl -m -u -r

The number should differ from the results in step 3.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Marcel de Rooy 2013-07-11 13:35:55 UTC
QA Comment: Tiny patch. Looks good to me. 

Passed QA
Comment 5 Galen Charlton 2013-07-11 14:04:47 UTC
Pushed to master.  Thanks, Mark!
Comment 6 Tomás Cohen Arazi 2013-07-16 19:02:05 UTC
This patch has been pushed to 3.12.x, will be in 3.12.2.

Thanks Mark!
Comment 7 Bernardo Gonzalez Kriegel 2013-08-04 13:44:20 UTC
Pushed to 3.10.x, will be in 3.10.10