If as a non-logged-in user you try to access public lists from the lists button on the OPAC login page it will say there are no public lists. In fact the list of public lists is not made available to the login page by Auth.pm.
Created attachment 19491 [details] [review] Bug 10553 - Public lists not available from OPAC login page If you are not logged in to the OPAC, looking at the login page, and you click the Lists button to see public lists it says there are none. This patch corrects Auth.pm so that it loads the list of public lists in this situation. To test you must have at least one public list. Make sure you are logged out of the OPAC and visit the login page (/cgi-bin/koha/opac-user.pl). Clicking the "Lists" button should show you a list of public shelves.
Hi Owen, I haven't tested this, but I think there might be one case where we don't want to show any lists on the login page: when the opac is not public, but requires login for searching. Do you think this could be taken into account?
If OpacPublic is set to make the OPAC not public the lists button does not appear at all.
Cool, thx Owen.
Created attachment 19743 [details] [review] Bug 10553 - Public lists not available from OPAC login page If you are not logged in to the OPAC, looking at the login page, and you click the Lists button to see public lists it says there are none. This patch corrects Auth.pm so that it loads the list of public lists in this situation. To test you must have at least one public list. Make sure you are logged out of the OPAC and visit the login page (/cgi-bin/koha/opac-user.pl). Clicking the "Lists" button should show you a list of public shelves. Signed-off-by: Liz Rea <liz@catalyst.net.nz> works as described, and list button is not shown when opacpublic is disabled.
Created attachment 19749 [details] [review] Bug 10553 - Public lists not available from OPAC login page If you are not logged in to the OPAC, looking at the login page, and you click the Lists button to see public lists it says there are none. This patch corrects Auth.pm so that it loads the list of public lists in this situation. To test you must have at least one public list. Make sure you are logged out of the OPAC and visit the login page (/cgi-bin/koha/opac-user.pl). Clicking the "Lists" button should show you a list of public shelves. Signed-off-by: Liz Rea <liz@catalyst.net.nz> works as described, and list button is not shown when opacpublic is disabled. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
QA Comment: Works as advertised. Small change. Looks good to me. No complaints from koha-qa, no new warnings in log. Redefinition of $pubshelves in checkauth is not on same scope level. Passed QA
Pushed to master. Thanks, Owen!
Pushed to 3.10.x, will be in 3.10.11 Already present on 3.12.4
Pushed to 3.8.x, will be in 3.8.18