Currently, DisplayOPACiconsXSLT has a description of "On pages displayed with XSLT stylesheets on the OPAC, "show|don't show" icons for itemtype and authorized values." However, that is not its actual behaviour! Turning it on/off does show/hide OPAC icons in the XSLT... However, turning on/off "DisplayOPACiconsXSLT" also displays/hides information on the "Type", "Format", "Literary Form", etc. In other words, lots of valuable information from the fixed fields in the Leader, 006, 007, and/or 008. We should probably be checking $DisplayOPACiconsXSLT each time we go to print an IMG element, rather than encasing that whole block of text inside the $DisplayOPACiconsXSLT flag. We're losing valuable information if we turn off a system preference that is supposed to govern the display of icons.
Hi David, I think that's by design but it has a bad system preference description. The reason to hide the icons was that people don't have the correct information in their data, so the information drawn from the control fields would not be correct.
(In reply to Katrin Fischer from comment #1) > Hi David, I think that's by design but it has a bad system preference > description. The reason to hide the icons was that people don't have the > correct information in their data, so the information drawn from the control > fields would not be correct. Ahhh, if that's the case, I don't mind humbly withdrawing this bug report.
(In reply to David Cook from comment #2) > (In reply to Katrin Fischer from comment #1) > > Hi David, I think that's by design but it has a bad system preference > > description. The reason to hide the icons was that people don't have the > > correct information in their data, so the information drawn from the control > > fields would not be correct. > > Ahhh, if that's the case, I don't mind humbly withdrawing this bug report. Or perhaps I'll fix up the syspref description at some point as per Katrin's suggestion on IRC ;)
Is this bug still valid? The current description of the preference is: "[Show/Don't show] the format, audience, and material type icons in XSLT MARC21 results and detail pages in the OPAC."
(In reply to Owen Leonard from comment #4) > Is this bug still valid? The current description of the preference is: > > "[Show/Don't show] the format, audience, and material type icons in XSLT > MARC21 results and detail pages in the OPAC." I didn't check - I think you are right, that reads well!
(In reply to Katrin Fischer from comment #5) > (In reply to Owen Leonard from comment #4) > > Is this bug still valid? The current description of the preference is: > > > > "[Show/Don't show] the format, audience, and material type icons in XSLT > > MARC21 results and detail pages in the OPAC." > > I didn't check - I think you are right, that reads well. OK; rethinking: The issue David pointed out is that it doesn't just hide the icons, it hides the whole thing, including descriptions etc. - I think that's the thing David was pointing out: >However, turning on/off "DisplayOPACiconsXSLT" also displays/hides information >on the "Type", "Format", "Literary Form", etc. In other words, lots of valuable >information from the fixed fields in the Leader, 006, 007, and/or 008.
Created attachment 102791 [details] [review] Bug 10561:Rephrase DisplayOPACiconsXSLT and DisplayIconsXSLT slightly As the pref removes the whole 'line' of information, this tries to makes the behaviour a little clearer by adding a 'and descriptions' to the pref text. It now reads: [Show|Don't show] the format, audience, and material type icons and descriptions in XSLT MARC21 results and detail pages in ... To test: - Check both preference descriptions in the staff client - Verify the text reads correctly and this helps things
Created attachment 102792 [details] [review] Bug 10561:Rephrase DisplayOPACiconsXSLT and DisplayIconsXSLT slightly As the pref removes the whole 'line' of information, this tries to makes the behaviour a little clearer by adding a 'and descriptions' to the pref text. It now reads: [Show|Don't show] the format, audience, and material type icons and descriptions in XSLT MARC21 results and detail pages in ... To test: - Check both preference descriptions in the staff client - Verify the text reads correctly and this helps things
If this hides the icons and the descriptions should the name of the system preferences also change to reflect that?
(In reply to Lucas Gass from comment #9) > If this hides the icons and the descriptions should the name of the system > preferences also change to reflect that? We could, I just held off to cause not too much disruption (manuals, docuemtation etc.). Do you have a suggestion?
On the results page the class name of that element is 'results_material_type' on both the OPAC and staff side. On the details page the class name is 'type' on Maybe: DisplayOPACMaterialType DisplayMaterialType
Created attachment 103114 [details] [review] Bug 10561:Rephrase DisplayOPACiconsXSLT and DisplayIconsXSLT slightly As the pref removes the whole 'line' of information, this tries to makes the behaviour a little clearer by adding a 'and descriptions' to the pref text. It now reads: [Show|Don't show] the format, audience, and material type icons and descriptions in XSLT MARC21 results and detail pages in ... To test: - Check both preference descriptions in the staff client - Verify the text reads correctly and this helps things Signed-off-by: David Roberts <david@koha-ptfs.co.uk>
Created attachment 103255 [details] [review] Bug 10561:Rephrase DisplayOPACiconsXSLT and DisplayIconsXSLT slightly As the pref removes the whole 'line' of information, this tries to makes the behaviour a little clearer by adding a 'and descriptions' to the pref text. It now reads: [Show|Don't show] the format, audience, and material type icons and descriptions in XSLT MARC21 results and detail pages in ... To test: - Check both preference descriptions in the staff client - Verify the text reads correctly and this helps things Signed-off-by: David Roberts <david@koha-ptfs.co.uk> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Nice work everyone! Pushed to master for 20.05
(In reply to Lucas Gass from comment #11) > On the results page the class name of that element is > 'results_material_type' on both the OPAC and staff side. > > On the details page the class name is 'type' on > > Maybe: > > DisplayOPACMaterialType > DisplayMaterialType As this was pushed now - maybe we could/should move renaming to a new bug?
Backported to 19.11.x for 19.11.06
backported to 19.05.x for 19.05.11