We are showing the OPAC note from the subscription, but we should also show the internal note in the result list on the check expiration page.
Created attachment 19530 [details] [review] Bug 10570: Show nonpublic note on check expiration page The check expiration page in serials only showed the OPAC note, but it makes sense to also show the nonpublic note here. This patch adds it. To test: - Add a subscription, make sure to enter different notes in nonpublic note and OPAC note to check for display later on. - Go to the check expiration page and search for your subscription. - Check both notes show up correctly.
Created attachment 20175 [details] [review] [SIGNED-OFF] Bug 10570: Show nonpublic note on check expiration page The check expiration page in serials only showed the OPAC note, but it makes sense to also show the nonpublic note here. This patch adds it. To test: - Add a subscription, make sure to enter different notes in nonpublic note and OPAC note to check for display later on. - Go to the check expiration page and search for your subscription. - Check both notes show up correctly. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 21077 [details] [review] Bug 10570: Show nonpublic note on check expiration page The check expiration page in serials only showed the OPAC note, but it makes sense to also show the nonpublic note here. This patch adds it. To test: - Add a subscription, make sure to enter different notes in nonpublic note and OPAC note to check for display later on. - Go to the check expiration page and search for your subscription. - Check both notes show up correctly. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Pushed to master. Thanks, Katrin!
This patch has been pushed to 3.12.x, will be in 3.12.7. Thanks Katrina!