After introducing escaped $query_cgi in bugfix 9239 the results sort feature does not work correctly for the librarian. To reproduce the problem (in librarian's interface): 1. Have some biblio records to get a list when searching 2. Make an advanced search with 'as phrase' modifier (title -- ti,phr: or author -- au,phr: , etc.) 3. Having the result list try to change the sort order. 4. You should get no results with a message like: "No results match your search for 'au%2Cphr: " etc. A patch will follow.
Created attachment 19581 [details] [review] Proposed patch To test (in librarian's interface): 1. Have some biblio records to get a list when searching. 2. Make an advanced search with 'as phrase' modifier (title -- ti,phr: or author -- au,phr: , etc.) 3. Having the result list try to change the sort order. 4. You should get no results with a message like: "No results match your search for 'au%2Cphr: " etc. 5. Apply the patch 6. Repeat steps 2. & 3. 7. You should get the list sorted according to your choice.
Why not my @operators = map uri_unescape($_), $cgi->param('op'); etc
(In reply to Srdjan Jankovic from comment #2) > Why not > my @operators = map uri_unescape($_), $cgi->param('op'); > > etc Just to be consistent with how it looks like in analogous spots in opac/opac-search.pl... But feel free to modify if you think it is worth of.
Created attachment 19746 [details] [review] [SIGNED-OFF] Bug 10578 - Escaping CGI breaks results sort feature (librarian's interface) To test (in librarian's interface): 1. Have some biblio records to get a list when searching. 2. Make an advanced search with 'as phrase' modifier (title -- ti,phr: or author -- au,phr: , etc.) 3. Having the result list try to change the sort order. 4. You should get no results with a message like: "No results match your search for 'au%2Cphr: " etc. 5. Apply the patch 6. Repeat steps 2. & 3. 7. You should get the list sorted according to your choice. Signed-off-by: Srdjan <srdjan@catalyst.net.nz>
It is. I hate wasted CPU cycles.
Created attachment 19834 [details] [review] [PASSED QA] Bug 10578 - Escaping CGI breaks results sort feature (librarian's interface) To test (in librarian's interface): 1. Have some biblio records to get a list when searching. 2. Make an advanced search with 'as phrase' modifier (title -- ti,phr: or author -- au,phr: , etc.) 3. Having the result list try to change the sort order. 4. You should get no results with a message like: "No results match your search for 'au%2Cphr: " etc. 5. Apply the patch 6. Repeat steps 2. & 3. 7. You should get the list sorted according to your choice. Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works nicely, passes all tests and QA script.
Pushed to master. Thanks, Janusz!
This patch has been pushed to 3.12.x, will be in 3.12.4. Thanks Janusz!