Bug 10587 - HTML errors on authority detail page in OPAC
Summary: HTML errors on authority detail page in OPAC
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Owen Leonard
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-14 11:52 UTC by Katrin Fischer
Modified: 2014-12-07 20:02 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 10587 - HTML errors on authority detail page in OPAC (2.63 KB, patch)
2013-08-09 15:44 UTC, Owen Leonard 		Details | Diff | Splinter Review
Bug 10587: fix HTML errors on authority detail page in OPAC (2.65 KB, patch)
2013-08-14 14:42 UTC, Galen Charlton 		Details | Diff | Splinter Review
[PASSED QA] Bug 10587: fix HTML errors on authority detail page in OPAC (2.85 KB, patch)
2013-08-27 20:41 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2013-07-14 11:52:24 UTC 
When checking the source code for some ids and classed I found that Firefox showed some red error marks in the source code. It seems 2 divs are closed, but not opened. The W3C HTML validator also points out those:

Error Line 357, Column 10: End tag div seen, but there were open elements.
    </div>

Error Line 256, Column 24: Unclosed element ul.
    <ul class="seefrom">

Error Line 381, Column 6: Stray end tag div.
</div>
Comment 1 Owen Leonard 2013-08-09 15:44:38 UTC Comment hidden (obsolete)
Comment 2 Galen Charlton 2013-08-14 14:42:31 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2013-08-27 20:41:44 UTC 
Created attachment 20666 [details] [review]
[PASSED QA] Bug 10587: fix HTML errors on authority detail page in OPAC

A validator check of the OPAC's authority detail returns a few minor
errors. This patch corrects the errors.

To test, apply the patch and run an OPAC authority detail page through
an HTML validator. There should be no errors which are specific to the
authorities detail template (as opposed to header and footer includes).

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
All tests and QA script pass.
Also checked using the W3C validator and testing the
authority detail page in the OPAC is still correctly
displayed.
Comment 4 Galen Charlton 2013-08-28 13:47:29 UTC 
Pushed to master.  Thanks, Owen!
Comment 5 Tomás Cohen Arazi (tcohen) 2013-09-13 17:27:10 UTC 
This patch has been pushed to 3.12.x, will be in 3.12.5.

Thanks Owen!
Comment 6 Bernardo Gonzalez Kriegel 2013-10-13 13:24:04 UTC 
Pushed to 3.10.x, will be in 3.10.12