The commit for bug 9812 is causing certain files in {opac-tmpl,intranet-tmpl}/theme/lang/{modules,xslt,includes} from being fetched. From the Apache logs: [Mon Jul 15 14:28:21 2013] [error] [client 67.183.139.142] client denied by server configuration: /home/gmc/koha/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/marc21_field_008.xml, referer: http://staff.zadi.librarypolice.com/cgi-bin/koha/cataloguing/plugin_launcher.pl?plugin_name=marc21_field_008.pl&index=tag_008_subfield_00_798112_205206&result=800919s1941%20%20%20%20nyu%20%20%20%20%20%20%20%20%20%20%20000%200%20eng [Mon Jul 15 14:16:17 2013] [error] [client 67.183.139.142] client denied by server configuration: /home/gmc/koha/koha-tmpl/opac-tmpl/prog/en/includes/favicon.ico [Mon Jul 15 14:43:52 2013] [error] [client 67.183.139.142] client denied by server configuration: /home/gmc/koha/koha-tmpl/intranet-tmpl/prog/en/includes/favicon.ico The effects I've seen so far: [1] favicons aren't displayed [2] The cataloging plugins for the 006 and 008 MARC21 fields can't fetch their XML data files, thus breaking them.
Created attachment 19676 [details] [review] bug 10592: fix MARC21 006/008 cataloging plugins Move the XML and XSD data files so that access to them (particularly the XML files) is not blocked by the Apache configuration change introduced by the patch for bug 9812. To test, after applying the patch. [1] Open a MARC21 bibliographic record in the cataloging editor. [2] Click on the plugin link for the 008 field. Verify that that the form for all of the fixed field positions is displayed, and verify that you can change the type of material. [3] Repeat step 2 for the 006 field. [4] Verify that there are no entries in the Apache error log that contain client denied by server configuration: {...}/cataloguing/value_builder/marc21_field_008.xml or client denied by server configuration: {...}/cataloguing/value_builder/marc21_field_006.xml Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Created attachment 19677 [details] [review] bug 10592: fix display of favicon Move the favicon files for OPAC and staff so that they are not blocked by the Apache configuration change introduced by the patch for bug 9812. Note that this patch makes the favicon customizable by theme, not both theme and language. To test, after applying the patch. [1] Open pages in the OPAC and staff client. Verify that the favicon is displayed in the usual place in your web browser. Specific pages to test include - circulation receipts and slips - help - lists view - web-based self-checkout [2] Verify that the Apache logs do not contain entries like this: client denied by server configuration: {...}/prog/en/includes/favicon.ico Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Created attachment 19815 [details] [review] bug 10592: fix MARC21 006/008 cataloging plugins Move the XML and XSD data files so that access to them (particularly the XML files) is not blocked by the Apache configuration change introduced by the patch for bug 9812. To test, after applying the patch. [1] Open a MARC21 bibliographic record in the cataloging editor. [2] Click on the plugin link for the 008 field. Verify that that the form for all of the fixed field positions is displayed, and verify that you can change the type of material. [3] Repeat step 2 for the 006 field. [4] Verify that there are no entries in the Apache error log that contain client denied by server configuration: {...}/cataloguing/value_builder/marc21_field_008.xml or client denied by server configuration: {...}/cataloguing/value_builder/marc21_field_006.xml Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Created attachment 19816 [details] [review] bug 10592: fix display of favicon Move the favicon files for OPAC and staff so that they are not blocked by the Apache configuration change introduced by the patch for bug 9812. Note that this patch makes the favicon customizable by theme, not both theme and language. To test, after applying the patch. [1] Open pages in the OPAC and staff client. Verify that the favicon is displayed in the usual place in your web browser. Specific pages to test include - circulation receipts and slips - help - lists view - web-based self-checkout [2] Verify that the Apache logs do not contain entries like this: client denied by server configuration: {...}/prog/en/includes/favicon.ico Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Created attachment 19830 [details] [review] [PASSED QA] Bug 10592: fix MARC21 006/008 cataloging plugins Move the XML and XSD data files so that access to them (particularly the XML files) is not blocked by the Apache configuration change introduced by the patch for bug 9812. To test, after applying the patch. [1] Open a MARC21 bibliographic record in the cataloging editor. [2] Click on the plugin link for the 008 field. Verify that that the form for all of the fixed field positions is displayed, and verify that you can change the type of material. [3] Repeat step 2 for the 006 field. [4] Verify that there are no entries in the Apache error log that contain client denied by server configuration: {...}/cataloguing/value_builder/marc21_field_008.xml or client denied by server configuration: {...}/cataloguing/value_builder/marc21_field_006.xml Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Also verified translation of those plugins still works correctly.
Created attachment 19831 [details] [review] [PASSED QA] Bug 10592: fix display of favicon Move the favicon files for OPAC and staff so that they are not blocked by the Apache configuration change introduced by the patch for bug 9812. Note that this patch makes the favicon customizable by theme, not both theme and language. To test, after applying the patch. [1] Open pages in the OPAC and staff client. Verify that the favicon is displayed in the usual place in your web browser. Specific pages to test include - circulation receipts and slips - help - lists view - web-based self-checkout [2] Verify that the Apache logs do not contain entries like this: client denied by server configuration: {...}/prog/en/includes/favicon.ico Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Verified that the favicon displays correctly. Also tried changing favicons for staff and OPAC using the system preferences for those. This still works, where the system preferences are correctly supported in the templates.
Pushed to master.