The holds button in cat-toolbar is broken for "search to hold". It is a split button rather than a dropdown button. Clicking the caret works fine, but clicked the button sends you to the marc editor!
Created attachment 19696 [details] [review] Bug 10597 - Search to hold button broken on record details The holds button in cat-toolbar is broken for "search to hold". It is a split button rather than a dropdown button. Clicking the caret works fine, but clicked the button sends you to the marc editor! Test Plan: 1) View a patron's details page 2) Click 'search to hold' 3) Search for something 4) On the results page, click a result line's title link ( catalogue/detail.pl ) 5) Note the "Place hold" button is a split button, click the left half of the button, note it redirects you to the editor. 6) Apply this patch 7) Repeat steps 1-5
Created attachment 19702 [details] [review] [SIGNED-OFF] Bug 10597 - Search to hold button broken on record details The holds button in cat-toolbar is broken for "search to hold". It is a split button rather than a dropdown button. Clicking the caret works fine, but clicked the button sends you to the marc editor! Test Plan: 1) View a patron's details page 2) Click 'search to hold' 3) Search for something 4) On the results page, click a result line's title link ( catalogue/detail.pl ) 5) Note the "Place hold" button is a split button, click the left half of the button, note it redirects you to the editor. 6) Apply this patch 7) Repeat steps 1-5 Signed-off-by: Srdjan <srdjan@catalyst.net.nz>
QA comment: Simple patch, works as expected. Marked as Passed QA.
Created attachment 19760 [details] [review] Bug 10597 - Search to hold button broken on record details The holds button in cat-toolbar is broken for "search to hold". It is a split button rather than a dropdown button. Clicking the caret works fine, but clicked the button sends you to the marc editor! Test Plan: 1) View a patron's details page 2) Click 'search to hold' 3) Search for something 4) On the results page, click a result line's title link ( catalogue/detail.pl ) 5) Note the "Place hold" button is a split button, click the left half of the button, note it redirects you to the editor. 6) Apply this patch 7) Repeat steps 1-5 Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Pushed to master. Thanks, Kyle! I note that there are two other staff templates that contain the text 'place hold for': ./modules/catalogue/results.tt ./modules/virtualshelves/shelves.tt Making a parameterized template to implement the widget would be a Good Thing for consistency's sake.
This patch has been pushed to 3.12.x, will be in 3.12.4. Thanks Kyle!