Bug 10604 - two columns in the courses table aren't wide enough
Summary: two columns in the courses table aren't wide enough
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Course reserves (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Galen Charlton
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-17 14:28 UTC by Galen Charlton
Modified: 2014-12-07 20:02 UTC (History)
0 users

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 10604: increase width of two columns in the courses table (3.10 KB, patch)
2013-07-17 14:40 UTC, Galen Charlton
Details | Diff | Splinter Review
Bug 10604: increase width of two columns in the courses table (3.15 KB, patch)
2013-07-20 03:47 UTC, Chris Cormack
Details | Diff | Splinter Review
[PASSED QA] Bug 10604: increase width of two columns in the courses table (3.32 KB, patch)
2013-07-21 09:02 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Galen Charlton 2013-07-17 14:28:51 UTC
Both courses.department and courses.term refer to authorized values, and consequently should be varchar(80) to match authorised_values.authorised_value.  They're currently varchar(20).
Comment 1 Galen Charlton 2013-07-17 14:40:16 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2013-07-20 03:47:49 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2013-07-21 09:02:09 UTC
Created attachment 19828 [details] [review]
[PASSED QA] Bug 10604: increase width of two columns in the courses table

The department and term columns in the courses table started
as varchar(20), but since they refer to authorized values, need
to be varchar(80) to match authorised_values.authorised_value.  This
patch increases the width of those columns.

To test:

[1] Create two DEPARTMENT authorised values, one whose code
    is shorter than 20 characters and one whose code is longer
    than 20 characters.
[2] Create two courses; give one course the short department and
    the other the long department.
[3] Go to the courses list.  Observe that the department column is
    displays the department name only for the short course.
[4] Apply the patch.
[5] Edit the course with the long department and assign that long
    department to it again.
[6] Go back to the courses list.  Observe that both of the courses
    now display their assigned department.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Verified changes are consistent for new installations
and updated installations.
Passes all tests.
Comment 4 Galen Charlton 2013-07-22 14:47:22 UTC
Pushed to master.