Bug 10651 - Use new DataTables include in administration templates
Summary: Use new DataTables include in administration templates
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Jonathan Druart
URL:
Keywords:
Depends on: 10649
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-26 15:29 UTC by Owen Leonard
Modified: 2014-12-07 20:02 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Medium patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 10651 - Use new DataTables include in administration templates (11.99 KB, patch)
2013-09-10 15:38 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 10651 - Use new DataTables include in administration templates (12.07 KB, patch)
2013-09-19 23:41 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
Bug 10651 - Use new DataTables include in administration templates (12.31 KB, patch)
2013-09-20 08:43 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 10651 - Followup Use new DataTables include in administration templates (1.56 KB, patch)
2013-09-20 08:43 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2013-07-26 15:29:31 UTC
Administration templates which use the DataTables plugin should be updated to use the new DataTables include file introduced by Bug 10649.
Comment 1 Owen Leonard 2013-09-10 15:38:53 UTC Comment hidden (obsolete)
Comment 2 Bernardo Gonzalez Kriegel 2013-09-19 23:41:25 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2013-09-20 08:43:45 UTC
Created attachment 21269 [details] [review]
Bug 10651 - Use new DataTables include in administration templates

Bug 10649 introduced a new include file for adding DataTables-related
JavaScript assets. This patch adds use of this include file to all
administration-related pages which use DataTables.

To test, view the following pages and confirm that table sorting is
still working correctly:

- Administration -> Budgets
- Administration -> Authority types -> MARC structure
- Administration -> Authorized values
- Administration -> Library transfer limits
- Administration -> Libraries and groups
- Administration -> Patron types and categories
- Administration -> Cities and towns
- Administration -> Item types
- Administration -> MARC bibliographic framework -> MARC structure
- Administration -> System preferences
- Administration -> System preferences -> Local use
- Administration -> Z39.50 client targets

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Comment: Sorting works. No koha-qa errors

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 4 Jonathan Druart 2013-09-20 08:43:50 UTC
Created attachment 21270 [details] [review]
Bug 10651 - Followup Use new DataTables include in administration templates

The aqbudgets.tt needs to use the include file too.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 5 Jonathan Druart 2013-09-20 08:46:29 UTC
QA comment:

The admin fund page was missing.
Owen, could you explain me why the css file is not include in the include file please?

Marked as Passed QA.
Comment 6 Owen Leonard 2013-09-20 12:46:28 UTC
(In reply to Jonathan Druart from comment #5)

> Owen, could you explain me why the css file is not include in the include
> file please?

Perhaps it would have been better to do it that way. I was thinking of a time in the future when I would like to move all JavaScript to the end of each page instead of the beginning, and CSS would need to stay at the top.
Comment 7 Galen Charlton 2013-09-21 19:36:51 UTC
Pushed to master.  Thanks, Owen!