Bug 10661 - Mandatory item fields should be formatted the same on all forms
Summary: Mandatory item fields should be formatted the same on all forms
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-29 21:12 UTC by Katrin Fischer
Modified: 2015-06-04 23:23 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 10661 - Mandatory item fields should be formatted the same on all forms (6.79 KB, patch)
2013-08-15 14:19 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 10661 - Mandatory item fields should be formatted the same on all forms (8.22 KB, patch)
2013-08-15 19:58 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 10661 - Mandatory item fields should be formatted the same on all forms (14.03 KB, patch)
2013-09-11 15:24 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 10661 - Mandatory item fields should be formatted the same on all forms (14.06 KB, patch)
2013-10-20 21:46 UTC, David Cook
Details | Diff | Splinter Review
[PASSED-QA] Bug 10661 - Mandatory item fields should be formatted the same on all forms (14.12 KB, patch)
2013-10-24 00:15 UTC, Brendan Gallagher
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2013-07-29 21:12:45 UTC
While we mark the mandatory fields with red font color in cataloguing, the item forms in serials and acquisitions (order from staged file, item form on order entry) are still using an asterisk * to indicate mandatory fields.
We should use the same formatting on all forms for more consistency.
Comment 1 Owen Leonard 2013-08-15 14:19:54 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2013-08-15 19:58:39 UTC Comment hidden (obsolete)
Comment 3 Liz Rea 2013-08-22 23:42:12 UTC
Hi Owen,

Looks like it works, but on my display, in serials, the width of the table seems to bump the red "required" text to the next line - http://img547.imageshack.us/img547/5568/qjij.png

I  hate to mark it failed because it's not a failure per-se... just needs a tweak.

Cheers,
Liz
Comment 4 Owen Leonard 2013-08-26 19:54:50 UTC
(In reply to Liz Rea from comment #3)
> Looks like it works, but on my display, in serials, the width of the table
> seems to bump the red "required" text to the next line

The size of the fields is consistent across different pages, the form being generated by PrepareItemrecordDisplay in Items.pm.

However, the size of those fields is pretty huge: the size attribute has them at 67. Other fields are just 50. I'm not sure why the difference?
Comment 5 Owen Leonard 2013-09-11 15:24:41 UTC Comment hidden (obsolete)
Comment 6 I'm just a bot 2013-09-29 05:56:37 UTC
Patch applied cleanly, go forth and signoff
Comment 7 David Cook 2013-10-20 21:46:02 UTC Comment hidden (obsolete)
Comment 8 David Cook 2013-10-20 21:46:58 UTC
Attaching my notes here as git bz was timing out insanely fast so I couldn't add them to the commit...

"Works as described. I tried the serial and acquisitions test plans. 
They look much better and uniform now.

It's worth mentioning that the serials module uses the Default 
framework when adding items. We might want to have it look for SER
or SERIAL or something like that like ACQ for Acquisitions. Just
a note though."
Comment 9 Brendan Gallagher 2013-10-24 00:15:46 UTC
Created attachment 22343 [details] [review]
[PASSED-QA] Bug 10661 - Mandatory item fields should be formatted the same on all forms

Mandatory item fields are not indicated the same way in all places. This
patch corrects two places where required fields were shown in bold
rather than using the standard "required" class: When adding an order
from a staged file and when adding an item for a new issue of a serial.

This patch also normalizes the text input size on item entry forms: In
some places it was 50, others 67. I have changed the latter to 50.

Unrelated changes: Added $KohaDates formatting of date and time and
corrected capitalization on a heading on the add order from staged file
page.

It would be nice to be able to use the same method for displaying the
item form as we use on neworderentry.tt -- pulling in the form from a
separate include. However that system is designed for handling multiple
items and would need to be adapted for these cases.

To test, you must have a staged file from which to add an order. Open an
existing basket or create a new one and choose to add an order "From a
staged file." Choose a staged file from which to order. The item entry
form under the "Import all" heading should show required fields in red.

To test in serials: Begin the process for receiving an item from an
existing subscription. On the serials-edit page, find the "Click to add
item" links and click to open the item edit forms. There should be one
under the numbered issue and the supplemental issue forms. In both cases
the item edit screen should show the mandatory item fields in red.

Confirm that the cataloging add item form looks correct and works
correctly.

Revision: Left out the "required" note which should appear after each
required field.

Signed-off-by: David Cook <dcook@prosentient.com.au>
Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Comment 10 Galen Charlton 2013-12-10 04:19:01 UTC
Pushed to master.  Thanks, Owen!
Comment 11 Fridolin Somers 2013-12-24 10:03:37 UTC
Patch pushed to 3.14.x, will be in 3.14.2.