Bug introduced by http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8378 If there is no active currency, when running overdue_notices.pl you get a sofware error "Can't use an undefined value as a HASH reference" on GetCurrency() function call
Created attachment 19991 [details] [review] Bug 10664 : Software error in overdue_notices.pl if there is no active currency If there is no active currency, when running overdue_notices.pl you get a sofware error "Can't use an undefined value as a HASH reference" on GetCurrency() function call With this patch, if there is no active currency, fines are formated by default 0,00 and notices are correctly generated. Test plan : - have at least one borrower with overdue that should trigger a notice - verify that there is no active currency (Adminitration > Currency & Exchange rates) - run misc/cronjobs/overdue_notices.pl -v -n (to get the notice directly on output) => without the patch you get the software error => with the patch, notices are correctly generated If an active currency is defined, the script overdue_notices.pl runs the same with or without patch
Created attachment 20032 [details] [review] [SIGNED-OFF] Bug 10664 : Software error in overdue_notices.pl if there is no active currency If there is no active currency, when running overdue_notices.pl you get a sofware error "Can't use an undefined value as a HASH reference" on GetCurrency() function call With this patch, if there is no active currency, fines are formated by default 0,00 and notices are correctly generated. Test plan : - have at least one borrower with overdue that should trigger a notice - verify that there is no active currency (Adminitration > Currency & Exchange rates) - run misc/cronjobs/overdue_notices.pl -v -n (to get the notice directly on output) => without the patch you get the software error => with the patch, notices are correctly generated If an active currency is defined, the script overdue_notices.pl runs the same with or without patch Signed-off-by: Srdjan <srdjan@catalyst.net.nz>
Currency stuff should be moved out of Budgets.pm ASAP. It is ridiculous for Output.pm to depend on Budgets.pm
Created attachment 20396 [details] [review] Bug 10664 : Software error in overdue_notices.pl if there is no active currency If there is no active currency, when running overdue_notices.pl you get a sofware error "Can't use an undefined value as a HASH reference" on GetCurrency() function call With this patch, if there is no active currency, fines are formated by default 0,00 and notices are correctly generated. Test plan : - have at least one borrower with overdue that should trigger a notice - verify that there is no active currency (Adminitration > Currency & Exchange rates) - run misc/cronjobs/overdue_notices.pl -v -n (to get the notice directly on output) => without the patch you get the software error => with the patch, notices are correctly generated If an active currency is defined, the script overdue_notices.pl runs the same with or without patch Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 20397 [details] [review] Bug 10664 [QA Followup] - Software error in overdue_notices.pl if there is no active currency Fixes the following koha-qa.pl error: FAIL misc/cronjobs/overdue_notices.pl OK pod OK forbidden patterns OK valid FAIL critic # Variables::ProhibitConditionalDeclarations:
Pushed to master. Thanks, Sophie!
This patch has been pushed to 3.12.x, will be in 3.12.4. Thanks Sophie!
Pushed to 3.10.x, will be in 3.10.11
Pushed to 3.8.x, will be in 3.8.19