In t/db_dependent/Koha.t, the test "Got a quote based on today's date" is failing : $prove t/db_dependent/Koha.t : t/db_dependent/Koha.t .. 1/6 # Failed test 'Got a quote based on today's date.' # at t/db_dependent/Koha.t line 126. # Compared $data->{"source"} # got : 'Herbert Hoover' # expect : 'Abraham Lincoln' # Be sure to run this test on a clean install of sample data. # Looks like you failed 1 test of 4. # Failed test 'Daily Quotes Test' # at t/db_dependent/Koha.t line 129. Looks like the wrong quote is returned by GetDailyQuote(). I'm using a databased created with the English sample SQL datas. I think I found the cause : The test "Got a random quote." calls GetDailyQuote('random'=>1) which changes the quote timestamp to now. When then testing GetDailyQuote(), this quote (which may not be the one created by test) is the most recent quote.
Created attachment 19998 [details] [review] Bug 10666 - Daily quotes tests are failing See commit message.
Created attachment 20001 [details] [review] Bug 10666 - Daily quotes tests are failing In t/db_dependent/Koha.t, the test "Got a quote based on today's date" is failing : $prove t/db_dependent/Koha.t : t/db_dependent/Koha.t .. 1/6 # Failed test 'Got a quote based on today's date.' # at t/db_dependent/Koha.t line 126. # Compared $data->{"source"} # got : 'Herbert Hoover' # expect : 'Abraham Lincoln' # Be sure to run this test on a clean install of sample data. # Looks like you failed 1 test of 4. Looks like the wrong quote is returned by GetDailyQuote(). I'm using a databased created with the English sample SQL datas. I think I found the cause : The test "Got a random quote." calls GetDailyQuote('random'=>1) which changes the quote timestamp to now. When then testing GetDailyQuote(), this quote (which may not be the one created by test) is the most recent quote. This patch moves the "Got a random quote." test after "Got a quote based on today's date" to solve the problem. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Works for me, and since it would be nice to make Jenkins happy (and hopefully no longer have it noisily report essentially false test suite failures), I've pushed this to master. Fridolyn, thanks!
Worked for me -- because my VM was set to UTC+0. I've pushed a follow-up that improves the fix.
This patch has been pushed to 3.12.x, will be in 3.12.4. Thanks Fridolyn!
Pushed to 3.10.x, will be in 3.10.11