.../cgi-bin/koha/ilsdi.pl?service=Describe&verb=AuthenticatePatron Currently only username + password is supported. Authentication should also be possible with cardnumber + password to match OPAC authentication.
Created attachment 20884 [details] [review] Bug 10667: Add unit tests for ILSDI::Services::AuthenticatePatron This patch adds unit tests for Authenticate patron. To test: - Run perl t/db_dependent/ILSDI_Services.t - Verify all tests pass Note: there are some tests marked as TODO. Rewriting AuthenticatePatron to make cardnumber and userid work for authenticating a patron will be implemented in the next patch. Tests related to this are currently showing as 'not ok', but are still passing.
Created attachment 20885 [details] [review] Bug 10667: Allow authentication with cardnumber for ILS-DI Test authentication via ILS-DI: - with userid and password - with userid and wrong password - with cardnumber and password - with cardnumber and wrong password ... Before the patch only userid will authenticate the patron. After the patch was applied, userid and cardnumber will work. To test: - Run t/db_dependent/ILSDI_Services.t - all tests should pass.
Created attachment 20888 [details] [review] [SIGNED-OFF] Bug 10667: Add unit tests for ILSDI::Services::AuthenticatePatron This patch adds unit tests for Authenticate patron. To test: - Run perl t/db_dependent/ILSDI_Services.t - Verify all tests pass Note: there are some tests marked as TODO. Rewriting AuthenticatePatron to make cardnumber and userid work for authenticating a patron will be implemented in the next patch. Tests related to this are currently showing as 'not ok', but are still passing. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> No koha-qa errors With both patches applied, all test pass.
Created attachment 20889 [details] [review] [SIGNED-OFF] Bug 10667: Allow authentication with cardnumber for ILS-DI Test authentication via ILS-DI: - with userid and password - with userid and wrong password - with cardnumber and password - with cardnumber and wrong password ... Before the patch only userid will authenticate the patron. After the patch was applied, userid and cardnumber will work. To test: - Run t/db_dependent/ILSDI_Services.t - all tests should pass. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> No koha-qa errors Test: Enable ISL-DI access opac with /cgi-bin/koha/ilsdi.pl?service=AuthenticatePatron&username=XXX&password=YYY With userid/cardnumber & password returns borrowernumber With userid/cardnumber & wrong password returns PatronNotFound
Hm, I think I have to fail this - it looks like my adding use Auth; to Services.pm breaks the packaging process.
Created attachment 20998 [details] [review] Bug 10667: Follow up - prevent t/00-load from failing To test: - Apply first 2 patches for unit tests and changes to Services.pm - Turn off mysql - Run t/00-load.t - Verify that the test fails. - Apply this third patch. - Run t/00-load.t again. - Verify this time it passes.
Created attachment 21007 [details] [review] [SIGNED-OFF] Bug 10667: Follow up - prevent t/00-load from failing To test: - Apply first 2 patches for unit tests and changes to Services.pm - Turn off mysql - Run t/00-load.t - Verify that the test fails. - Apply this third patch. - Run t/00-load.t again. - Verify this time it passes. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Work well, no koha-qa errors. Without third patch and mysql down, test fails, with third patch it succeed.
Created attachment 21064 [details] [review] Bug 10667: Add unit tests for ILSDI::Services::AuthenticatePatron This patch adds unit tests for Authenticate patron. To test: - Run perl t/db_dependent/ILSDI_Services.t - Verify all tests pass Note: there are some tests marked as TODO. Rewriting AuthenticatePatron to make cardnumber and userid work for authenticating a patron will be implemented in the next patch. Tests related to this are currently showing as 'not ok', but are still passing. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> No koha-qa errors With both patches applied, all test pass. Signed-off-by: Mason James <mtj@kohaaloha.com>
Created attachment 21065 [details] [review] Bug 10667: Allow authentication with cardnumber for ILS-DI Test authentication via ILS-DI: - with userid and password - with userid and wrong password - with cardnumber and password - with cardnumber and wrong password ... Before the patch only userid will authenticate the patron. After the patch was applied, userid and cardnumber will work. To test: - Run t/db_dependent/ILSDI_Services.t - all tests should pass. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> No koha-qa errors Test: Enable ISL-DI access opac with /cgi-bin/koha/ilsdi.pl?service=AuthenticatePatron&username=XXX&password=YYY With userid/cardnumber & password returns borrowernumber With userid/cardnumber & wrong password returns PatronNotFound Signed-off-by: Mason James <mtj@kohaaloha.com>
Created attachment 21067 [details] [review] Bug 10667: Follow up - prevent t/00-load from failing To test: - Apply first 2 patches for unit tests and changes to Services.pm - Turn off mysql - Run t/00-load.t - Verify that the test fails. - Apply this third patch. - Run t/00-load.t again. - Verify this time it passes. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Work well, no koha-qa errors. Without third patch and mysql down, test fails, with third patch it succeed. Signed-off-by: Mason James <mtj@kohaaloha.com>
patches pass all ./t/tests and qa-tool passing QA on 3 patches
Pushed to master. Thanks, Katrin!
This patch has been pushed to 3.12.x, will be in 3.12.7. Thanks Katrin!