Created attachment 20035 [details] [review] Bug 10670 - koha-common fails to start zebra without log permissions If koha-common is started when zebra log files are owned by root it will fail to start without any useful message (since zebra can't write errors in log files because it lacks permissions to do so). This patch creates empty log files and ensure they have correct permissions. I can't pin-point why log files gets owned root, but I suspect it has something to do with zebra crashing and logrotate, but this is just theory. We have seen this behaviour since koha 3.1 every few months, and every time it happends we have root owned logs and crashed zebra so this patch will at least help sites which have some kind of automatic koha-common start if it's not running.
Patch applied cleanly, go forth and signoff
Created attachment 22952 [details] [review] Bug 10670 - koha-common fails to start zebra without log permissions If koha-common is started when zebra log files are owned by root it will fail to start without any useful message (since zebra can't write errors in log files because it lacks permissions to do so). This patch creates empty log files and ensure they have correct permissions. I can't pin-point why log files gets owned root, but I suspect it has something to do with zebra crashing and logrotate, but this is just theory. We have seen this behaviour since koha 3.1 every few months, and every time it happends we have root owned logs and crashed zebra so this patch will at least help sites which have some kind of automatic koha-common start if it's not running. Signed-off-by: Robin Sheat <robin@catalyst.net.nz>
A small, harmless, and useful change.
I consider this a bugfix, not an enhancement, so I've pushed this to master and 3.14.x. Thanks, Dobrica!
This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Dobrica!