In a serials module, when searching subscriptions, the results table as a "Notes" column. In TT code, you see that it tries to display public note "subscription.notes" and internal note "subscription.internalnotes". Internal note is well displayed but not public note. You can see the 2 notes in serial details in summary tab.
Created attachment 20124 [details] [review] Bug 10689 - public note does not appear in subscriptions search See commit message
Created attachment 20125 [details] [review] Bug 10689 - public note does not appear in subscriptions search better commit message
Hi Fridolyn. It works well, so I sign off. But I have found SearchSubscriptions is used 2 times in code : ./serials/serials-search.pl ./acqui/newordersubscription.pl So I think you need to make changes too to the template used by newordersubscription.pl (I have checked : there is always one note on this page). Maybe in an other patch? Mathieu
Created attachment 21100 [details] [review] [PATCH][SIGNED OFF] Bug 10689 - public note does not appear in subscriptions search
Created attachment 21207 [details] [review] Bug 10689 - public note does not appear in new order form a subscription Indeed. Here is a follow-up for acquisition. Thanks a lot ;)
Patch applied cleanly, go forth and signoff
Created attachment 21598 [details] [review] [SIGNED-OFF] Bug 10689 - public note does not appear in subscriptions search In a serials module, when searching subscriptions, the results table as a "Notes" column. In TT code, you see that it tries to display public note "subscription.notes" and internal note "subscription.internalnotes". Internal note is well displayed but not public note. You can see the 2 notes in serial details in summary tab. The problem commes from the SQL query. A join is perform on subscription and biblio, both containing a "notes" column. This patch solves the problem by using a alias in query for both columns (biblio.notes is acutally not used in template but could be). Test plan : - Edit a subscription - Add public and internal notes. For example : "too busy" and "on holiday" - Perform a subscription search that returns this subscription => "Notes" column contains both notes. For example : "too busy (on holiday)" - Test with only public note - Test with only internal note ==== Works as described. Signed-off-by:Mathieu Saby <mathieu.saby@uhb.fr> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Adding a sign
Created attachment 21599 [details] [review] [SIGNED-OFF] Bug 10689 - public note does not appear in new order form a subscription Test by creating a new order to a basket using "From a subscription" link Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Works as described. No koha-qa errors When creating a new basket from a susbcription, public note shows on Notes column.
Created attachment 21602 [details] [review] [PASSED QA] Bug 10689 - public note does not appear in subscriptions search In a serials module, when searching subscriptions, the results table as a "Notes" column. In TT code, you see that it tries to display public note "subscription.notes" and internal note "subscription.internalnotes". Internal note is well displayed but not public note. You can see the 2 notes in serial details in summary tab. The problem commes from the SQL query. A join is perform on subscription and biblio, both containing a "notes" column. This patch solves the problem by using a alias in query for both columns (biblio.notes is acutally not used in template but could be). Test plan : - Edit a subscription - Add public and internal notes. For example : "too busy" and "on holiday" - Perform a subscription search that returns this subscription => "Notes" column contains both notes. For example : "too busy (on holiday)" - Test with only public note - Test with only internal note ==== Works as described. Signed-off-by:Mathieu Saby <mathieu.saby@uhb.fr> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Adding a sign Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> All tests and QA script pass. Works as described, fixes a bug as the templates show that the intention was to display both notes in the column.
Created attachment 21603 [details] [review] [PASSED QA] Bug 10689 - public note does not appear in new order form a subscription Test by creating a new order to a basket using "From a subscription" link Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Works as described. No koha-qa errors When creating a new basket from a susbcription, public note shows on Notes column. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Tiny enhancement, passes tests and QA script. Works as described.
Pushed to master, along with a follow-up that adds a regression test. Thanks, Fridolyn!
This patch has been pushed to 3.12.x, will be in 3.12.7. Thanks Fridolyn!