The descriptions of OPACBaseURL and staffClientBaseURL are not explicit about whether a trailing slash should be included in the URLs or not. But: <jcamins> Folks: if you have a trailing slash in your OPACBaseURL or staffClientBaseURL, REMOVE IT! <jcamins> I've been trying to troubleshoot weird firewall issues with 3.12 for one of my clients ever since the upgrade, and it turns out that the firewall was going nuts because of URLs like catalog.com//cgi-bin/koha/opac-detail.pl. <jcamins> Almost certainly a firewall misconfiguration, of course, but it's easy enough to work around on the server. Patch coming up!
Created attachment 20131 [details] [review] Bug 10690 - Warn about trailing slashes in description of OPACBaseURL and staffClientBaseURL The descriptions for OPACBaseURL and staffClientBaseURL are not explicit about including a trailing slash or not. This patch makes it explicit that the trailing slash should *not* be included. To test: - Apply the patch - Search for "baseurl" in the system preferences - Check that the description of both sysprefs includes a warning about not including a trailing slash. - Sign off If you want to check that the trailing slash is in fact superfluous you can do something like 'grep -r "BaseURL" *' and check that these sysprefs are usually concatenated with some string that starts with a slash.
Created attachment 20190 [details] [review] Bug 10690 - Warn about trailing slashes in description of OPACBaseURL and staffClientBaseURL The descriptions for OPACBaseURL and staffClientBaseURL are not explicit about including a trailing slash or not. This patch makes it explicit that the trailing slash should *not* be included. To test: - Apply the patch - Search for "baseurl" in the system preferences - Check that the description of both sysprefs includes a warning about not including a trailing slash. - Sign off If you want to check that the trailing slash is in fact superfluous you can do something like 'grep -r "BaseURL" *' and check that these sysprefs are usually concatenated with some string that starts with a slash. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Created attachment 20608 [details] [review] [PASSED QA] Bug 10690 - Warn about trailing slashes in description of OPACBaseURL and staffClientBaseURL The descriptions for OPACBaseURL and staffClientBaseURL are not explicit about including a trailing slash or not. This patch makes it explicit that the trailing slash should *not* be included. To test: - Apply the patch - Search for "baseurl" in the system preferences - Check that the description of both sysprefs includes a warning about not including a trailing slash. - Sign off If you want to check that the trailing slash is in fact superfluous you can do something like 'grep -r "BaseURL" *' and check that these sysprefs are usually concatenated with some string that starts with a slash. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Changes to the description appear correctly on both system preferences.
Pushed to master. Thanks, Magnus!
This patch has been pushed to 3.12.x, will be in 3.12.5. Thanks Magnus!
Pushed to 3.10.x, will be in 3.10.12