Currently, position 01 isn't loaded into the plugin editor for the 007 field in MARC21. This is because the template expects 1 character but the perl script is trying to pass in 4 characters. I can see no reason for this and when I do a git blame, it looks like this might be an accidental holdover from a past implementation of the plugin editor. If we switch the perl script to pass 1 character instead of 4, the plugin editor works as it should and I see no undesirable behaviours.
Created attachment 20282 [details] [review] Bug 10715 - MARC21 007 Plugin Editor doesn't load position 01 This patch changes the MARC21 007 plugin editor so that it uses 1 character instead of 4 characters for position 01. TEST PLAN: 1) Create new record/edit an existing record 2) Using the tag editor for the 007 field, choose "Videorecording" 3) Click OK 4) Change the second character in the 007 from "c" to "d" 5) Open the tag editor again 6) Note that position 01 will still say "c - Videocartridge" rather than "d - Videodisc". 7) Exit tag editor 8) Apply patch 9) Reload the page (Shift + Refresh is always useful) 10) Open the tag editor again 11) Note that position 01 will now say "d - Videodisc"
Created attachment 20334 [details] [review] Bug 10715 - MARC21 007 Plugin Editor doesn't load position 01 This patch changes the MARC21 007 plugin editor so that it uses 1 character instead of 4 characters for position 01. TEST PLAN: 1) Create new record/edit an existing record 2) Using the tag editor for the 007 field, choose "Videorecording" 3) Click OK 4) Change the second character in the 007 from "c" to "d" 5) Open the tag editor again 6) Note that position 01 will still say "c - Videocartridge" rather than "d - Videodisc". 7) Exit tag editor 8) Apply patch 9) Reload the page (Shift + Refresh is always useful) 10) Open the tag editor again 11) Note that position 01 will now say "d - Videodisc" Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Created attachment 20399 [details] [review] Bug 10715 - MARC21 007 Plugin Editor doesn't load position 01 This patch changes the MARC21 007 plugin editor so that it uses 1 character instead of 4 characters for position 01. TEST PLAN: 1) Create new record/edit an existing record 2) Using the tag editor for the 007 field, choose "Videorecording" 3) Click OK 4) Change the second character in the 007 from "c" to "d" 5) Open the tag editor again 6) Note that position 01 will still say "c - Videocartridge" rather than "d - Videodisc". 7) Exit tag editor 8) Apply patch 9) Reload the page (Shift + Refresh is always useful) 10) Open the tag editor again 11) Note that position 01 will now say "d - Videodisc" Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Pushed to master. Thanks, David!
been pushed to 3.12.x, will be in 3.12.5. Thanks David!
Pushed to 3.10.x, will be in 3.10.11
Pushed to 3.8.x, will be in 3.8.19