Bug 10716 - The booksellers template generates a JS error
Summary: The booksellers template generates a JS error
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on: 5766
Blocks: 10533
  Show dependency tree / graph
 
Reported: 2013-08-13 10:25 UTC by Jonathan Druart
Modified: 2014-12-07 20:02 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 10716: the basketgroup template does not include all datatables file. (1.37 KB, patch)
2013-08-13 10:27 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Bug 10716: fix JavaScript error on basket groups page (1.41 KB, patch)
2013-08-14 14:59 UTC, Galen Charlton 		Details | Diff | Splinter Review
Bug 10716: fix JavaScript error on basket groups page (1.47 KB, patch)
2013-08-16 14:36 UTC, Kyle M Hall (khall) 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2013-08-13 10:25:15 UTC 
Bug 5766 introduces a js error on acqui/basketgroup.tt because it is bad formed (does not include all datatable file).
Comment 1 Jonathan Druart 2013-08-13 10:27:46 UTC Comment hidden (obsolete)
Comment 2 Galen Charlton 2013-08-14 14:59:26 UTC Comment hidden (obsolete)
Comment 3 Kyle M Hall (khall) 2013-08-16 14:36:23 UTC 
Created attachment 20414 [details] [review]
Bug 10716: fix JavaScript error on basket groups page

To test:

Go on acqui/basketgroup.tt and verify a js error occurred
(ReferenceError: CONFIG_EXCLUDE_ARTICLES_FROM_SORT is not defined).
Apply the patch and verify the error does not appear anymore.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 4 Galen Charlton 2013-08-16 14:44:42 UTC 
Pushed to master.  Thanks, Jonathan!
Comment 5 Tomás Cohen Arazi (tcohen) 2013-09-11 17:19:24 UTC 
This patch has been pushed to 3.12.x, will be in 3.12.5.

Thanks Jonathan!