In overdue notices we use some text enclosed by << >> or < > for substitution. At the end of the process, if some of this text still remains, a warn is printed in logfile and the remaining substitution is erased. This procedure prevents to use html tag in notices, needed to format display with css for example. If a susbstitution text does not match any valid term and is not a valid html tag, it should be corrected notice template itself (and warn help to do this) but not systematically deleted.
Created attachment 20320 [details] [review] Bug 10720 : substitution term in overdue notices shouldn't be removed if they don't match. It prevents use of html in notices to use with css Test plan : - define an overdue notice containing some valid substitution terms + some valid html tags (<strong> or <div class="my class" to use with a css - find a borrower with overdues that trigger this notice - run overdue_notices.pl -html <directory> Without patch, your html tags are missing in your html file With the patch, they are present and can be used with a css to generate a formatted pdf file. If you add some invalid substitution term, with the patch, they are still in the final letter, but the warn in the log helps you to correct your notice template.
Created attachment 20756 [details] [review] Bug 10720 : substitution term in overdue notices shouldn't be removed if they don't match. It prevents use of html in notices to use with css Test plan : - define an overdue notice containing some valid substitution terms + some valid html tags (<strong> or <div class="my class" to use with a css - find a borrower with overdues that trigger this notice - run overdue_notices.pl -html <directory> Without patch, your html tags are missing in your html file With the patch, they are present and can be used with a css to generate a formatted pdf file. If you add some invalid substitution term, with the patch, they are still in the final letter, but the warn in the log helps you to correct your notice template. Signed-off-by: Srdjan <srdjan@catalyst.net.nz>
I've removed those lines, this script should use GetPreparedLetter anyway.
Created attachment 20829 [details] [review] Bug 10720 : substitution term in overdue notices shouldn't be removed if they don't match. It prevents use of html in notices to use with css Test plan : - define an overdue notice containing some valid substitution terms + some valid html tags (<strong> or <div class="my class" to use with a css - find a borrower with overdues that trigger this notice - run overdue_notices.pl -html <directory> Without patch, your html tags are missing in your html file With the patch, they are present and can be used with a css to generate a formatted pdf file. If you add some invalid substitution term, with the patch, they are still in the final letter, but the warn in the log helps you to correct your notice template. Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Pushed to master. Thanks, Sophie!
This patch has been pushed to 3.12.x, will be in 3.12.7. Thanks Sophie!