10725 – Add filters on the pending orders table

Bug 10725 - Add filters on the pending orders table

Summary: Add filters on the pending orders table

Status:	CLOSED FIXED

Alias:	None

Product:	Koha
Classification:	Unclassified
Component:	Acquisitions (show other bugs)
Version:	Main
Hardware:	All All

Importance:	P5 - low enhancement
Assignee:	Jonathan Druart
QA Contact:	Testopia

URL:	acqui/parcel.pl
Keywords:

Depends on:	10724
Blocks:	10124
	Show dependency tree / graph

Reported:	2013-08-14 08:56 UTC by Jonathan Druart
Modified:	2014-05-26 21:04 UTC (History)
CC List:	1 user (show)

See Also:
Change sponsored?:	---
Patch complexity:	---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 10725: Add filters on the pending orders table (5.46 KB, patch) 2013-08-14 09:01 UTC, Jonathan Druart	Details \| Diff \| Splinter Review
Bug 10725: Add filters on the pending orders table (5.31 KB, patch) 2013-09-23 09:22 UTC, Jonathan Druart	Details \| Diff \| Splinter Review
[PASSED QA] Bug 10725: Add filters on the pending orders table (5.55 KB, patch) 2013-09-27 06:32 UTC, Katrin Fischer	Details \| Diff \| Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Jonathan Druart 2013-08-14 08:56:21 UTC

Datatable allows to easily adds filters on the table headers. It would be great to have them on the pending orders table.

Comment 1 Jonathan Druart 2013-08-14 09:01:20 UTC Comment hidden (obsolete)

Created attachment 20327 [details] [review]
Bug 10725: Add filters on the pending orders table

Since the parcel.pl script get *all* pending orders, there is no reason
not to display all of them.

Like that, DataTable manages pagination and sorting correctly (on all
data).
This patch adds filters on the table header (using columnFilter).

Test plan:
Try filters on the left of the screen and filters on the table header.

Signed-off-by: Pierre Angot <tredok.pierre@gmail.com>

Comment 2 Katrin Fischer 2013-09-22 12:24:10 UTC

Hi Jonathan,

could you rebase? I applied it on top of 10723+24 and there was a small conflict. I tried fixing it, but it doesn't look right - the table headers are doubled up now for me. Could you take a look and retest? Thx!

Comment 3 Jonathan Druart 2013-09-23 09:22:47 UTC Comment hidden (obsolete)

Created attachment 21350 [details] [review]
Bug 10725: Add filters on the pending orders table

Since the parcel.pl script get *all* pending orders, there is no reason
not to display all of them.

Like that, DataTable manages pagination and sorting correctly (on all
data).
This patch adds filters on the table header (using columnFilter).

Test plan:
Try filters on the left of the screen and filters on the table header.

Signed-off-by: Pierre Angot <tredok.pierre@gmail.com>

Comment 4 Katrin Fischer 2013-09-27 06:32:28 UTC

Created attachment 21507 [details] [review]
[PASSED QA] Bug 10725: Add filters on the pending orders table

Since the parcel.pl script get *all* pending orders, there is no reason
not to display all of them.

Like that, DataTable manages pagination and sorting correctly (on all
data).
This patch adds filters on the table header (using columnFilter).

Test plan:
Try filters on the left of the screen and filters on the table header.

Signed-off-by: Pierre Angot <tredok.pierre@gmail.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passes all tests and QA script.
Searching and sorting the table works correctly.
Larger result sets are a performance problem on this page,
I have filed bug 10595 for that.

Comment 5 Galen Charlton 2013-10-30 05:10:49 UTC

Pushed to master.  Thanks, Jonathan!