Some more cases as the ones solved on Bug 6278, now on NORMARCslim2intranetDetail.xsl and MARC21slim2intranetDetail.xsl
Created attachment 20431 [details] [review] Bug 10745 - More fun on translation bug with XSLT subfieldSelect parameters As in Bug 6278, this patch replace ">at<" with ">a_t<" so not to mislead translators. Found more cases that initial description. To test: 1) Check that problem exists and only on xslt files, using your preferred language egrep -B10 "^msgid \"at\"" misc/translator/po/xx-YY-i-staff-t* 2) Apply the patch 3) Update translation file (cd misc/translator; perl translate update xx-YY) 4) Verify the problem is gone, repeat 1 5) If you like verify new entries in PO file egrep -B15 "^msgid \"a_t\"" misc/translator/po/xx-YY-i-staff-t*
Created attachment 20547 [details] [review] Bug 10745 - More fun on translation bug with XSLT subfieldSelect parameters As in Bug 6278, this patch replace ">at<" with ">a_t<" so not to mislead translators. Found more cases that initial description. To test: 1) Check that problem exists and only on xslt files, using your preferred language egrep -B10 "^msgid \"at\"" misc/translator/po/xx-YY-i-staff-t* 2) Apply the patch 3) Update translation file (cd misc/translator; perl translate update xx-YY) 4) Verify the problem is gone, repeat 1 5) If you like verify new entries in PO file egrep -B15 "^msgid \"a_t\"" misc/translator/po/xx-YY-i-staff-t* Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Tested this with field 780 and running a Dutch translation.
QA Comment: I know the author of the 6278 patch :) Since this construct works and is in the current code, we are making a consistent use of this workaround. Moving it to Passed QA
Could we please get another sign-off on this one? :)
Created attachment 20565 [details] [review] Bug 10745 - More fun on translation bug with XSLT subfieldSelect parameters As in Bug 6278, this patch replace ">at<" with ">a_t<" so not to mislead translators. Found more cases that initial description. To test: 1) Check that problem exists and only on xslt files, using your preferred language egrep -B10 "^msgid \"at\"" misc/translator/po/xx-YY-i-staff-t* 2) Apply the patch 3) Update translation file (cd misc/translator; perl translate update xx-YY) 4) Verify the problem is gone, repeat 1 5) If you like verify new entries in PO file egrep -B15 "^msgid \"a_t\"" misc/translator/po/xx-YY-i-staff-t* Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Tested this with field 780 and running a Dutch translation. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Pushed to master. Thanks, Bernardo!
This patch has been pushed to 3.12.x, will be in 3.12.4. Thanks Bernardo!
Pushed to 3.10.x, will be in 3.10.11