When creating a suggestion in the staff interface, Title is not a mandatory field like in the OPAC. If you try to add a suggestion without a title it won't be saved.
Created attachment 25539 [details] [review] Bug 10751 - Title should be mandatory for creating suggestions in staff The form for adding a new purchase suggestion in the staff client indicates that the title field is required but does nothing to enforce this rule. This can be handled client-side with HTML5 validation attributes and Koha's built-in validation plugin. This patch implements this. To test, apply the patch and go to Acquisitions -> Suggestions -> New purchase suggestion. Try submitting the form without entering a title. Doing so should trigger a validation warning. Submission of the form with valid data should work correctly. Editing an existing suggestion should also work correctly.
Created attachment 25559 [details] Purchase suggestion in staff, title field is mandatory I tested without patch; the title field is already mandatory (Enter nothing turns the filed to red and I get a message. Tested with Firefox 27 and Chrome 33
Hm, I didn't retest - maybe someone implemented it after I filed the bug? If the new patch is more consistent with formatting, maybe it can still be signed off?
Sorry, I mistaked aubout what the patch would do. Sign off follows.
Created attachment 25571 [details] [review] [Signed-off] Bug 10751 - Title should be mandatory for creating suggestions in staff The form for adding a new purchase suggestion in the staff client indicates that the title field is required but does nothing to enforce this rule. This can be handled client-side with HTML5 validation attributes and Koha's built-in validation plugin. This patch implements this. To test, apply the patch and go to Acquisitions -> Suggestions -> New purchase suggestion. Try submitting the form without entering a title. Doing so should trigger a validation warning. Submission of the form with valid data should work correctly. Editing an existing suggestion should also work correctly. The patch displays a message 'Required' near the title field. After submitting a empty title it changes to 'This field is required' Signed-off-by: Marc Véron <veron@veron.ch>
I think it was me - I should have retested. Also Owen write that for him no message appears I think - so maybe there is some other difference we haven't found yet.
Created attachment 25577 [details] [review] Bug 10751 - Title should be mandatory for creating suggestions in staff The form for adding a new purchase suggestion in the staff client indicates that the title field is required but does nothing to enforce this rule. This can be handled client-side with HTML5 validation attributes and Koha's built-in validation plugin. This patch implements this. To test, apply the patch and go to Acquisitions -> Suggestions -> New purchase suggestion. Try submitting the form without entering a title. Doing so should trigger a validation warning. Submission of the form with valid data should work correctly. Editing an existing suggestion should also work correctly. The patch displays a message 'Required' near the title field. After submitting a empty title it changes to 'This field is required' Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> The title field is required since commit d565fb02e9fca2ac9c506e4e7d44fd8b0d66f06a This one makes it more consistent with formatting. It makes sense.
Pushed to master. Thanks, Owen!
Pushed to 3.14.x, will be in 3.14.07
Pushed to 3.12.x will be in 3.12.13