Bug 10754 - HomeOrHoldingBranch and CircControl are described identically in the system preference editor
Summary: HomeOrHoldingBranch and CircControl are described identically in the system p...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-18 21:46 UTC by Katrin Fischer
Modified: 2020-06-04 20:32 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
screenshot of system preference editor (16.93 KB, image/png)
2013-08-18 21:46 UTC, Katrin Fischer
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2013-08-18 21:46:04 UTC
Created attachment 20451 [details]
screenshot of system preference editor

We have 2 system preferences that from their description in the system preferences editor do exactly the same thing, but offer different options:

CircControl: 
  Use the checkout and fines rules of ...
    - the library the item is from
    - the library the patron is from
    - the library you are logged in at

HomeOrHoldingBranch: 
  Use the checkout and fines rules of ...
    - the ibrary the item is from
    - the library the item was checked out from
    
  
In the systempreferences table the description is different:

CircControl:
  Used by Circulation to determine which branch of an item to check 
  with independent branches on, and by search to determine which 
  branch to choose for availability

HomeOrHoldingBranch:
  Specify the agency that controls the circulation and fines policy

Both preferences are used a multiple times in the code. I am currently not sure what the difference is. Bug 5159 also claims that CircControl is not only used when independentbranches is turned on.

Can someone clarify and help updating the documentation?
Comment 1 Mathieu Saby 2014-02-23 11:40:55 UTC
Bug still here in 3.14.3

Mathieu
Comment 2 Mathieu Saby 2014-02-23 11:46:12 UTC
I'm tyring to set up a new Koha instance, and I don't know at all what to do with those 2 prefs :(

Mathieu
Comment 3 Kyle M Hall 2015-01-21 14:53:41 UTC
For the most part the system goes like this for selecting circulation rules:
If CircControl is set to "the library you are logged in at" circ rules will be selected based on the logged in branchcode
If CircControl is set to "the library the patron is from" circ rules will be selected based on the patron's branchcode
If CircControl is set to "the library the item is from" circ rules will be selected based on the items branchcode where HomeOrHoldingBranch chooses if items.homebranch is used or items.holdingbranch is used.

Also, from my reading of master, it appears that the system preference in question is HomeOrHoldingBranch, not CircControl. That is, if IndependentBranches is enabled, and the item's branchcode does not match the logged in library branchcode ( the choosing of which is via HomeOrHoldingBranch ), the item cannot be issued ( unless you are a super-librarian ).


Really, what we should do is remove the "the library the item is from" option from CircControl and add "the library that owns the item" and "the library that is holding the item" so we can remove HomeOrHoldingBranch from the circulation rules logic altogether. Then, we can identify what HomeOrHoldingBranch still does, and rename it to something more descriptive and accurate.
Comment 4 Kyle M Hall 2015-01-21 14:55:02 UTC
For the most part the system goes like this for selecting circulation rules:

1) If CircControl is set to "the library you are logged in at" circ rules will be selected based on the logged in branchcode

2) If CircControl is set to "the library the patron is from" circ rules will be selected based on the patron's branchcode

3) If CircControl is set to "the library the item is from" circ rules will be selected based on the items branchcode where HomeOrHoldingBranch chooses if items.homebranch is used or items.holdingbranch is used.

Also, if IndependentBranches is enabled, and the item's branchcode ( the choosing of which is via HomeOrHoldingBranch ) does not match the logged in library branchcode , the item cannot be issued ( unless you are a super-librarian ).

Really, what we should do is remove the "the library the item is from" option from CircControl and add "the library that owns the item" and "the library that is holding the item" so we can remove HomeOrHoldingBranch from the circulation rules logic altogether. Then, we can identify what HomeOrHoldingBranch still does, and rename it to something more descriptive and accurate.
Comment 5 Kyle M Hall 2015-01-21 14:55:34 UTC
Ignore comment 3, I rewrote it as comment 4 to make it more readable.
Comment 6 Nicole C. Engard 2015-01-21 15:07:36 UTC
I updated the manual (changes will be available tomorrow) to note these differences - please let me know if I should edit them:

http://manual.koha-community.org/3.18/en/administration.html#CircControl
http://manual.koha-community.org/3.18/en/administration.html#HomeOrHoldingBranch
http://manual.koha-community.org/3.18/en/patscirc.html#circfinerules
Comment 7 Katrin Fischer 2015-05-15 21:52:33 UTC
(In reply to Kyle M Hall from comment #4)
> For the most part the system goes like this for selecting circulation rules:
> 
> 1) If CircControl is set to "the library you are logged in at" circ rules
> will be selected based on the logged in branchcode
> ...

Thx for explaining Kyle!
Comment 8 Nick Clemens 2019-07-02 15:51:55 UTC
This seems to be explained and updated to the manual, closing