Bug 10755 - Add "Keyword as Phrase" to staff client advanced search indexes
Summary: Add "Keyword as Phrase" to staff client advanced search indexes
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: David Cook
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-19 01:20 UTC by David Cook
Modified: 2014-12-07 20:02 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 10755 - Add "Keyword as Phrase" to staff client advanced search indexes (1.64 KB, patch)
2013-08-19 01:38 UTC, David Cook
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 10755 - Add "Keyword as Phrase" to staff client advanced search indexes (1.90 KB, patch)
2013-08-22 13:35 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 10755 - Add "Keyword as Phrase" to staff client advanced search indexes (1.98 KB, patch)
2013-08-30 13:07 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description David Cook 2013-08-19 01:20:21 UTC
Currently, there are "...as Phrase" indexes for title, author, subject, corporate name, personal name, and conference name in the staff client. 

At the request of several librarians, this patch adds one for "Keyword". 

While we have had some discussion/debate about the best way to go forward with the available indexes in the OPAC, there's really no reason not to include this one in the staff client, especially since your more advanced searchers are (possibly) going to be librarians using the staff interface.
Comment 1 David Cook 2013-08-19 01:38:20 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2013-08-22 13:35:25 UTC Comment hidden (obsolete)
Comment 3 Kyle M Hall 2013-08-30 13:07:10 UTC
Created attachment 20737 [details] [review]
Bug 10755 - Add "Keyword as Phrase" to staff client advanced search indexes

This patch adds a "Keyword as Phrase" index to the search options in
the staff client.

Test Plan:

1) Go to the Advanced Search in the staff client and click on the "Keyword"
drop-down list.
2) Note that there is only a "Keyword" not a "Keyword as Phrase" option
3) Apply the patch
4) Reload the Advanced Search
5) Note that there is now a "Keyword as Phrase" option as well

If you want to test the functionality...it will depend on your catalogue
data.

Basically, a phrase search will allow you to find "Keyword Adjacent To
Keyword" rather than a more scattershot search that finds the keywords
regardless of their position to each other.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Template change is correct, and in my tests the searching behavior was
correctly modified: Using "keyword as phrase" returned only results
where the terms were adjacent.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Passes koha-qa.pl, trivial patch with no possible side effects.
Comment 4 Galen Charlton 2013-09-04 14:27:00 UTC
Pushed to master.  Thanks, David!
Comment 5 Tomás Cohen Arazi 2013-09-13 18:06:41 UTC
This patch has been pushed to 3.12.x, will be in 3.12.5.

Thanks David!