Bug 10765 - Update POD of C4::Koha::GetSupportList() to use TT syntax
Summary: Update POD of C4::Koha::GetSupportList() to use TT syntax
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Documentation (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Owen Leonard
QA Contact: Jonathan Druart
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-19 16:06 UTC by Owen Leonard
Modified: 2015-06-04 23:23 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 10765 - Update POD of C4::Koha::GetSupportList() to use TT syntax (1.95 KB, patch)
2013-08-19 16:08 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 10765 - [SIGNED-OFF] Update POD of C4::Koha::GetSupportList() to use TT syntax (2.26 KB, patch)
2013-08-20 08:27 UTC, Magnus Enger
Details | Diff | Splinter Review
Bug 10765 - [SIGNED-OFF] Update POD of C4::Koha::GetSupportList() to use TT syntax (2.38 KB, patch)
2013-08-20 11:54 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2013-08-19 16:06:14 UTC
The POD of  C4::Koha::GetSupportList() has an example of how to create an item type selector based on the output of the function, but it uses the old template syntax, not TT syntax.
Comment 1 Owen Leonard 2013-08-19 16:08:12 UTC Comment hidden (obsolete)
Comment 2 Magnus Enger 2013-08-20 08:27:58 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2013-08-20 11:54:38 UTC
Created attachment 20501 [details] [review]
Bug 10765 - [SIGNED-OFF] Update POD of C4::Koha::GetSupportList() to use TT syntax

This patch updates the example template syntax in the POD for
C4::Koha::GetSupportList() to use Template Toolkit syntax.

To test, view the POD for  C4::Koha::GetSupportList() and confirm that
it looks correct.

Signed-off-by: Magnus Enger <magnus@enger.priv.no>
This patch works as advertised (verified with "perldoc C4::Koha"),
for GetSupportList, but it does not fix a a similar example for
GetItemTypes, getauthtypes and getframework in the same file,
which still has the old template syntax. So a followup or separate
bug(s) for those are called for.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
It seems the default option is not in used in templates.
Comment 4 Galen Charlton 2013-08-20 14:34:03 UTC
Pushed to master.  Thanks, Owen!
Comment 5 Tomás Cohen Arazi 2013-09-13 14:39:29 UTC
This patch has been pushed to 3.12.x, will be in 3.12.5.

Thanks Owen!
Comment 6 Bernardo Gonzalez Kriegel 2013-09-15 01:43:55 UTC
Pushed to 3.10.x, will be in 3.10.11
Comment 7 Chris Hall 2013-11-22 22:04:49 UTC
Pushed to 3.8.x, will be in 3.8.20.