Commit 144c7f4e caused a regression on reservoir search. When UseQueryParser is off, the $query variable is munged to include an index specifier -- for example, "harry" becomes "kw,wrdl,rtrn=harry". However, BreedingSearch() does not recognize that form of query. Consequently, when UseQueryParser is off, cataloging search will essentially never turn up any results from the reservoir.
Created attachment 20485 [details] [review] Bug 10766: unbreak reservoir search when UseQueryParser is OFF To test: [1] Turn UseQueryParser off. [2] Ensure that your database has records in the reservoir. Performing a Z39.50 search will do this. [3] Perform a broad cataloging (i.e., cataloguing/addbooks.pl search). Note that results are returned from the main catalog but that no reservoir results are returned. [4] Apply the patch. [5] Perform the search again. This time, there should be both catalog and reservoir results. [7] Enable QueryParser. Perform the search again, and verify that the catalog and reservoir results are the same. Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Created attachment 20551 [details] [review] [SIGNED-OFF] Bug 10766: unbreak reservoir search when UseQueryParser is OFF To test: [1] Turn UseQueryParser off. [2] Ensure that your database has records in the reservoir. Performing a Z39.50 search will do this. [3] Perform a broad cataloging (i.e., cataloguing/addbooks.pl search). Note that results are returned from the main catalog but that no reservoir results are returned. [4] Apply the patch. [5] Perform the search again. This time, there should be both catalog and reservoir results. [7] Enable QueryParser. Perform the search again, and verify that the catalog and reservoir results are the same. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 20589 [details] [review] [PASSED QA] Bug 10766: unbreak reservoir search when UseQueryParser is OFF To test: [1] Turn UseQueryParser off. [2] Ensure that your database has records in the reservoir. Performing a Z39.50 search will do this. [3] Perform a broad cataloging (i.e., cataloguing/addbooks.pl search). Note that results are returned from the main catalog but that no reservoir results are returned. [4] Apply the patch. [5] Perform the search again. This time, there should be both catalog and reservoir results. [7] Enable QueryParser. Perform the search again, and verify that the catalog and reservoir results are the same. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Patch works nicely, passes all tests, and the QA script.
Pushed to master.
Cherry-picked to 3.12.x here: http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=4309e5e6b4682b95db4ca26f7a49f96c2f6c2875