Bug 10767 - UT: Routines which interact with the table issuingrules in C4/Circulation need unit test
Summary: UT: Routines which interact with the table issuingrules in C4/Circulation nee...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal
Assignee: kenza
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-20 08:37 UTC by kenza
Modified: 2014-12-07 20:02 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 10767: UT:Routines which interact with the table issuingrules in C4/Circulation need unit tests (13.38 KB, patch)
2013-08-20 08:43 UTC, kenza 		Details | Diff | Splinter Review
Bug 10767: UT:Routines which interact with the table issuingrules in C4/Circulation need unit tests (13.54 KB, patch)
2013-08-25 23:11 UTC, Bernardo Gonzalez Kriegel 		Details | Diff | Splinter Review
Bug 10767: UT:Routines which interact with the table issuingrules in C4/Circulation need unit tests (13.59 KB, patch)
2013-08-27 10:01 UTC, Chris Cormack 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description kenza 2013-08-20 08:37:35 UTC 
Test for GetHardDueDate GetIssuingRule GetLoanLength
Comment 1 kenza 2013-08-20 08:43:33 UTC Comment hidden (obsolete)
Comment 2 Bernardo Gonzalez Kriegel 2013-08-25 23:11:17 UTC Comment hidden (obsolete)
Comment 3 Chris Cormack 2013-08-27 10:01:54 UTC 
Created attachment 20651 [details] [review]
Bug 10767: UT:Routines which interact with the table issuingrules in C4/Circulation need unit tests

The test are wrap in a transaction.

NOTE: Some tests (in comment)  don't pass, the routines have to be fixed

To test:
prove t/db_dependent/Circulation_Issuingrule.t
t/db_dependent/Circulation_Issuingrule.t .. ok
All tests successful.
Files=1, Tests=9, 17 wallclock secs ( 0.02 usr  0.00 sys +  0.34 cusr  0.04 csys =  0.40 CPU)
Result: PASS

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Comment: No koha-qa errors
prove t/db_dependent/Circulation_Issuingrule.t run without errors

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Comment 4 Galen Charlton 2013-08-28 14:47:20 UTC 
Pushed to master.  Thanks, Kenza!

I did, however, also push a follow-up removing the FIXME comments -- GetIssuingRules() is not a traditional accessor, and should not be returning multiple rules in any event.
Comment 5 Tomás Cohen Arazi (tcohen) 2013-09-13 18:01:03 UTC 
This patch has been pushed to 3.12.x, will be in 3.12.5.

Thanks Kenza!