Bug 10772 - IE7 not loading reset-fonts-grids.css in staff client
Summary: IE7 not loading reset-fonts-grids.css in staff client
Status: CLOSED WONTFIX
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-21 02:10 UTC by David Cook
Modified: 2015-06-04 23:23 UTC (History)
0 users

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Cook 2013-08-21 02:10:41 UTC
Currently, we're importing "reset-fonts-grids.css" into the staff client using "@import url("../lib/yui/reset-fonts-grids.css") screen;" in staff-global.css.

This works great in Chrome, (probably Firefox), and IE8+. 

However, "reset-fonts-grids.css" isn't being loaded in IE7 (and probably under) in the staff client, because IE doesn't seem to support media queries with the @import rule. It'll work fine without the media query, but with it...we get nothing.

Currently, we're using a "screen" media query, which Owen added with Bug 10108, so that we can generate print outs without using the YUI grid system. This was important because a lot of print outs in the staff client were getting formatted poorly due to the use of the YUI grids when printing.

--

The only solutions to this problem that I see are either creating print specific stylesheets (which modern browsers would import but that IE7 wouldn't) or to create IE7 (and under) style sheets that we target using IE-specific HTML comments.)

Owen/others have any thoughts on this one? I know that the popular vote is not to support older versions of IE, but there are still lots of people out there using it. Lots of Koha users use it. So I would prefer to give them the best possible interface that we can, even if it is irritating to ensure backwards compatibility.
Comment 1 Owen Leonard 2013-08-21 12:30:05 UTC
Official we don't even support "modern" versions of IE, but in practice we do our best to fix bugs as they are reported.

I have no interest in making dramatic changes to support IE7, but I don't object to a conditional comment in doc-head-close.inc targeting < IE7 in order to load reset-fonts-grids.css:

<!--[if lte IE 7]>
<link rel="stylesheet" type="text/css" href="[% themelang %]/lib/yui/reset-fonts-grids.css" />
<![endif]-->
Comment 2 David Cook 2013-08-21 23:55:16 UTC
(In reply to Owen Leonard from comment #1)
> Official we don't even support "modern" versions of IE, but in practice we
> do our best to fix bugs as they are reported.
> 
> I have no interest in making dramatic changes to support IE7, but I don't
> object to a conditional comment in doc-head-close.inc targeting < IE7 in
> order to load reset-fonts-grids.css:
> 
> <!--[if lte IE 7]>
> <link rel="stylesheet" type="text/css" href="[% themelang
> %]/lib/yui/reset-fonts-grids.css" />
> <![endif]-->

That sounds like a reasonable suggestion to me :).
Comment 3 David Cook 2014-11-09 23:36:40 UTC
I don't know if this is necessary anymore. If this hasn't come up in a year, it's probably fine.