Right now, holds can only be suspended and resumed from the OPAC as a whole. It would be nice to be able to suspend and resume holds on a hold by hold basis from the OPAC.
Created attachment 20534 [details] [review] Bug 10774 - Allow individual holds to be suspended and resumed from the OPAC Right now, holds can only be suspended and resumed from the OPAC as a whole. It would be nice to be able to suspend and resume holds on a hold by hold basis from the OPAC. Test Plan: 1) Apply this patch 2) Log in to the OPAC 3) Place a number of holds 4) Browse to "my summary" and select the holds tab 5) From here, test the following actions a) Suspend a hold indefinitely ( no resume date ) b) Suspend a hold with a date to automatically resume c) Manually resume a suspended hold
Created attachment 20535 [details] [review] Bug 10774 - Allow individual holds to be suspended and resumed from the OPAC Right now, holds can only be suspended and resumed from the OPAC as a whole. It would be nice to be able to suspend and resume holds on a hold by hold basis from the OPAC. Test Plan: 1) Apply this patch 2) Log in to the OPAC 3) Place a number of holds 4) Browse to "my summary" and select the holds tab 5) From here, test the following actions a) Suspend a hold indefinitely ( no resume date ) b) Suspend a hold with a date to automatically resume c) Manually resume a suspended hold 6) Disable AutoResumeSuspendedHolds, ensure the suspend until date field is no longer visible. 7) Disable SuspendHoldsOpac, ensure all suspension related fields are no longer visible.
This looks good and is a nice improvement. I do see one issue: I'm pretty sure you shouldn't be able to suspend a hold on an item which is in transit. You can't cancel a hold while it is in transit, and the staff client blocks you from suspending. If that sounds correct and you'll submit a revision, there is also an orphan </p> which needs to be removed, right after the "clear date" link.
Good catches! I'll get a followup written asap. (In reply to Owen Leonard from comment #3) > This looks good and is a nice improvement. I do see one issue: I'm pretty > sure you shouldn't be able to suspend a hold on an item which is in transit. > You can't cancel a hold while it is in transit, and the staff client blocks > you from suspending. > > If that sounds correct and you'll submit a revision, there is also an orphan > </p> which needs to be removed, right after the "clear date" link.
Created attachment 20710 [details] [review] Bug 10774 - Allow individual holds to be suspended and resumed from the OPAC Right now, holds can only be suspended and resumed from the OPAC as a whole. It would be nice to be able to suspend and resume holds on a hold by hold basis from the OPAC. Test Plan: 1) Apply this patch 2) Log in to the OPAC 3) Place a number of holds 4) Browse to "my summary" and select the holds tab 5) From here, test the following actions a) Suspend a hold indefinitely ( no resume date ) b) Suspend a hold with a date to automatically resume c) Manually resume a suspended hold 6) Disable AutoResumeSuspendedHolds, ensure the suspend until date field is no longer visible. 7) Disable SuspendHoldsOpac, ensure all suspension related fields are no longer visible.
Patch applied cleanly, go forth and signoff
Patch tested per test plan, and functions as expected. I Chris Rohde, signoff on this patch.
Looks good, the patch works as expected. No regression found. Marked as Passed QA.
Created attachment 23211 [details] [review] Bug 10774 - Allow individual holds to be suspended and resumed from the OPAC Right now, holds can only be suspended and resumed from the OPAC as a whole. It would be nice to be able to suspend and resume holds on a hold by hold basis from the OPAC. Test Plan: 1) Apply this patch 2) Log in to the OPAC 3) Place a number of holds 4) Browse to "my summary" and select the holds tab 5) From here, test the following actions a) Suspend a hold indefinitely ( no resume date ) b) Suspend a hold with a date to automatically resume c) Manually resume a suspended hold 6) Disable AutoResumeSuspendedHolds, ensure the suspend until date field is no longer visible. 7) Disable SuspendHoldsOpac, ensure all suspension related fields are no longer visible. Signed-off-by: Chris Rohde <crohde@roseville.ca.us> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Created attachment 23212 [details] [review] [ALT] Bug 11244: notices ignoring the dateformat preference Overdue notices are using the MySQL date format and not the dateformat in the system preferences. Test Plan: 1) Enable checkout notices for a patron, make sure the date due is in the notice. 2) Check out an item to that patron, note the date is in the mysql datetime format 3) Apply this patch 4) Check out another item to the patron, not the date is now in the preferred date format.
Wrong bug number...
Pushing back to submitter for more work -- this patch series doesn't yet cover the bootstrap theme.
Created attachment 24016 [details] [review] Bug 10774 [QA Followup] - Add support for bootstrap opac theme
Created attachment 24017 [details] [review] Bug 10774 - Allow individual holds to be suspended and resumed from the OPAC Right now, holds can only be suspended and resumed from the OPAC as a whole. It would be nice to be able to suspend and resume holds on a hold by hold basis from the OPAC. Test Plan: 1) Apply this patch 2) Log in to the OPAC 3) Place a number of holds 4) Browse to "my summary" and select the holds tab 5) From here, test the following actions a) Suspend a hold indefinitely ( no resume date ) b) Suspend a hold with a date to automatically resume c) Manually resume a suspended hold 6) Disable AutoResumeSuspendedHolds, ensure the suspend until date field is no longer visible. 7) Disable SuspendHoldsOpac, ensure all suspension related fields are no longer visible. Signed-off-by: Chris Rohde <crohde@roseville.ca.us> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Created attachment 24018 [details] [review] Bug 10774 [QA Followup] - Add support for bootstrap opac theme
Pushed to master. Thanks, Kyle!