C4::ILSDI::Utility is not really required. It contains only two routines: * BorrowerExists() which is not used * Availability(), used only in C4::ILSDI::Services I propose we move Availability() to C4::ILSDI::Services and remove C4::ILSDI::Utility
Created attachment 20620 [details] [review] bug_10781: Removed ILSDI::Utility Test: This should be a noop. Regression testing required: /cgi-bin/koha/ilsdi.pl functioanality, in particuler: GetAvailability - ?service=Describe&verb=GetAvailability AuthenticatePatron - ?service=Describe&verb=AuthenticatePatron ILS-DI syspref must be turned on
Applying: bug_10781: Removed ILSDI::Utility /usr/share/koha/testclone/.git/rebase-apply/patch:43: tab in indent. my ($biblionumber, $status, $msg, $location) = _availability($id); warning: 1 line adds whitespace errors. Using index info to reconstruct a base tree... <stdin>:43: tab in indent. my ($biblionumber, $status, $msg, $location) = _availability($id); warning: 1 line applied after fixing whitespace errors. Falling back to patching base and 3-way merge... Removing t/ILSDI_Utility.t CONFLICT (modify/delete): C4/ILSDI/Utility.pm deleted in bug_10781: Removed ILSDI::Utility and modified in HEAD. Version HEAD of C4/ILSDI/Utility.pm left in tree. Auto-merging C4/ILSDI/Services.pm CONFLICT (content): Merge conflict in C4/ILSDI/Services.pm Failed to merge in the changes.
Created attachment 21688 [details] [review] bug_10781: Removed ILSDI::Utility Test: This should be a noop. Regression testing required: /cgi-bin/koha/ilsdi.pl functioanality, in particuler: GetAvailability - ?service=Describe&verb=GetAvailability AuthenticatePatron - ?service=Describe&verb=AuthenticatePatron ILS-DI syspref must be turned on
Patch applied cleanly, go forth and signoff
Created attachment 22402 [details] [review] bug_10781: Removed ILSDI::Utility Test: This should be a noop. Regression testing required: /cgi-bin/koha/ilsdi.pl functioanality, in particuler: GetAvailability - ?service=Describe&verb=GetAvailability AuthenticatePatron - ?service=Describe&verb=AuthenticatePatron ILS-DI syspref must be turned on Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 22725 [details] [review] bug_10781: Removed ILSDI::Utility Test: This should be a noop. Regression testing required: /cgi-bin/koha/ilsdi.pl functioanality, in particuler: GetAvailability - ?service=Describe&verb=GetAvailability AuthenticatePatron - ?service=Describe&verb=AuthenticatePatron ILS-DI syspref must be turned on Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
QA Comment: Tested both functions with ilsdi.pl. Works fine. Code looks good to me. No complaints from qa tools. Moving from enh to bugfix. No string changes. Still looks like a candidate for 3.14. Passed QA
Pushed to master. Thanks, Srdjan!
Patch pushed to 3.14.x, will be in 3.14.2