Bug 10786 - Javascript error on the parcel page: YAHOO is not defined
Summary: Javascript error on the parcel page: YAHOO is not defined
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-27 10:03 UTC by Jonathan Druart
Modified: 2014-12-07 20:02 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 10786: Javascript error on the parcel page: YAHOO is not defined (1.27 KB, patch)
2013-08-27 10:08 UTC, Jonathan Druart 		Details | Diff | Splinter Review
[SIGNED-OFF] Bug 10786: Javascript error on the parcel page: YAHOO is not defined (1.34 KB, patch)
2013-08-28 21:17 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Bug 10786: Javascript error on the parcel page: YAHOO is not defined (1.45 KB, patch)
2013-08-30 13:21 UTC, Kyle M Hall (khall) 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2013-08-27 10:03:11 UTC 

    


    


      

          
            
          


        
          Comment 1
        

        
          Jonathan Druart

        

        
        

        
          2013-08-27 10:08:06 UTC
        

          
            Comment hidden (obsolete)
          
      






    


    


      



        
          Comment 2
        

        
          Katrin Fischer

        

        
        

        
          2013-08-28 20:51:26 UTC
        

      






I am still having some problems after this patch is applied - I ran into the problem testing the patch for 10649 - also leaving a note there.

    


    


      

          
            
          


        
          Comment 3
        

        
          Katrin Fischer

        

        
        

        
          2013-08-28 21:17:18 UTC
        

          
            Comment hidden (obsolete)
          
      






    


    


      



        
          Comment 4
        

        
          Katrin Fischer

        

        
        

        
          2013-08-28 21:20:11 UTC
        

      






The invoicenumber I used led to a table with over 5.000 entries - using one with less lines this tested nicely.

    


    


      



        
          Comment 5
        

        
          Kyle M Hall (khall)

        

        
        

        
          2013-08-30 13:21:20 UTC
        

      






Created attachment 20738 [details] [review]
Bug 10786: Javascript error on the parcel page: YAHOO is not defined

The include of the yui json file generates a js error: YAHOO is not
defined.

This file seems not to be in use (patches for bug 8382 remove the use).

To test:
- go on acqui/parcel.pl?invoiceid=XXX
- verify the error occurs (with firebug)
- apply this patch
- refresh the page
- verify this error does not appear anymore
- Verify there is no regression on this page

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Patch fixes the javascript error pointed out by Firebug.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

    


    


      



        
          Comment 6
        

        
          Galen Charlton

        

        
        

        
          2013-09-04 17:00:50 UTC
        

      






Pushed to master.  Thanks, Jonathan!

    


    


      



        
          Comment 7
        

        
          Tomás Cohen Arazi (tcohen)

        

        
        

        
          2013-09-13 18:48:51 UTC
        

      






This patch has been pushed to 3.12.x, will be in 3.12.5.

Thanks Jonathan!

    


    


      



        
          Comment 8
        

        
          Bernardo Gonzalez Kriegel

        

        
        

        
          2013-10-13 13:26:49 UTC
        

      






Pushed to 3.10.x, will be in 3.10.12